Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][mig ][partner_second_lastname] #495

Merged
merged 7 commits into from Oct 27, 2017
Merged

[11.0][mig ][partner_second_lastname] #495

merged 7 commits into from Oct 27, 2017

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow commented Oct 13, 2017 •
edited by pedrobaeza

Standard migration to 11.0

Depends on

@JordiBForgeFlow JordiBForgeFlow added this to the 11.0 milestone Oct 13, 2017
@pedrobaeza pedrobaeza mentioned this pull request Oct 13, 2017
Closed
53 tasks
HviorForgeFlow
HviorForgeFlow approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional review

etobella
etobella approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

This module is WIP until the dependency is merged.

@pedrobaeza
Copy link
Member

Sorry, I see that is merged. Then a rebase is needed.

rgarnau
rgarnau approved these changes Oct 18, 2017
View reviewed changes
Copy link

@rgarnau rgarnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just one comment)

partner_second_lastname/README.rst
@@ -0,0 +1,100 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

njeudy
njeudy reviewed Oct 27, 2017
View reviewed changes
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Just install and test in a fresh 11.0 database

Ok for me

njeudy
njeudy approved these changes Oct 27, 2017
View reviewed changes
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Just install and test in a fresh 11.0 database

Ok for me

@JordiBForgeFlow JordiBForgeFlow merged commit 832f1d9 into OCA:11.0 Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njeudy njeudy njeudy approved these changes

@rgarnau rgarnau rgarnau approved these changes

@etobella etobella etobella approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
work in progress
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JordiBForgeFlow @pedrobaeza @njeudy @rgarnau @etobella @HviorForgeFlow @antespi @oca-transbot