11.0 mig partner contact nationality #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jprobineau did you work on this ? I can help or migrate |
| "summary": "Add nationality field to contacts", | ||
| 'version': '11.0.1.0.0', | ||
| "category": "Customer Relationship Management", | ||
| "website": "https://odoo-community.org/", |
There was a problem hiding this comment.
@jprobineau IMHO Please change URL as described in https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L10
|
Closing and reopening fixed the travis error (because partner_contact_personal_information_page was merged some time ago). But runbot error for some reason remains... |
|
Still no succes with opening and closing. |
NL66278
reviewed
Mar 20, 2020
| @@ -0,0 +1,5 @@ | |||
| # Copyright (C) 2014-2015 Grupo ESOC <www.grupoesoc.es> | |||
There was a problem hiding this comment.
Remove copyright lines from init files and make license lines https:
NL66278
reviewed
Mar 20, 2020
| @@ -0,0 +1,27 @@ | |||
| # Copyright (C) 2014-2015 Grupo ESOC <www.grupoesoc.es> | |||
| # © 2017-Apertoso N.V. (<http://www.apertoso.be>) | |||
There was a problem hiding this comment.
Replace copyright sign with just the word Copyright. No need for (C) either.
NL66278
requested changes
Mar 20, 2020
|
No action on comments and failing runbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.