Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][base_partner_sequence] fix unique ref on write #686

Merged
merged 1 commit into from May 8, 2019
Merged

[12.0][base_partner_sequence] fix unique ref on write #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions base_partner_sequence/models/partner.py
View file
Open in desktop
Expand Up @@ -32,10 +32,14 @@ def copy(self, default=None):
@api.multi
def write(self, vals):
for partner in self:
if not vals.get('ref') and partner._needsRef(vals) and \
not partner.ref:
vals['ref'] = partner._get_next_ref(vals=vals)
super(ResPartner, partner).write(vals)
partner_vals = vals.copy()
if (
not partner_vals.get('ref')
and partner._needsRef(partner_vals)
and not partner.ref
):
partner_vals['ref'] = partner._get_next_ref(vals=partner_vals)
super(ResPartner, partner).write(partner_vals)
return True

@api.multi
Expand Down
13 changes: 13 additions & 0 deletions base_partner_sequence/tests/test_base_partner_sequence.py
View file
Open in desktop
Expand Up @@ -33,3 +33,16 @@ def test_ref_sequence_on_contact(self):
self.assertEqual(
self.partner.ref, contact.ref, "All it's ok as sequence doesn't "
"increase.")

def test_unique_ref_on_write(self):
"""Assert that create and write gives a different refs if we """
vals = [
{'name': "test1", 'email': "test@test.com"},
{'name': "test2", 'email': "test@test.com"},
]
partners = self.env['res.partner'].create(vals)
self.assertFalse(partners[0].ref == partners[1].ref)
partners.write({'ref': False})
self.assertFalse(partners[0].ref)
partners.write({})
self.assertFalse(partners[0].ref == partners[1].ref)