Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] make res.partner.relation.all#write work for multiple records #731

Merged
merged 1 commit into from Apr 28, 2019
Merged

[FIX] make res.partner.relation.all#write work for multiple records #731

merged 1 commit into from Apr 28, 2019

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Apr 23, 2019

accessing self's fields in an @api.model function is dangerous, and we just need the model anyways. I changed this to always return a recordset, it will be falsy if empty

@hbrunn hbrunn requested a review from NL66278 April 23, 2019 13:19
@hbrunn hbrunn added this to the 10.0 milestone Apr 23, 2019
NL66278
NL66278 approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

tbaden
tbaden approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit f1f3bb4 into 10.0 Apr 28, 2019
@OCA-git-bot OCA-git-bot deleted the 10.0-partner_multi_relation-relation_all-write_multiple branch April 28, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NL66278 NL66278 NL66278 approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hbrunn @OCA-git-bot @NL66278 @tbaden @pedrobaeza