Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13.0 mig partner contact gender #792

Merged
merged 13 commits into from
Dec 2, 2019
Merged

13.0 mig partner contact gender #792

merged 13 commits into from
Dec 2, 2019

Conversation

Daemo00
Copy link
Contributor

@Daemo00 Daemo00 commented Oct 13, 2019 •
edited
Loading

Standard migration, plus a little refactor due to a pylint warning.

Depends on:

@oca-clabot
Copy link

Hey @Daemo00, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Daemo00
Copy link
Contributor Author

Daemo00 commented Oct 13, 2019

Depends on #788

@pedrobaeza pedrobaeza added this to the 13.0 milestone Oct 13, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 13, 2019
Open
47 tasks
@Daemo00 Daemo00 force-pushed the 13.0-mig-partner_contact_gender branch from 5e76b8c to 5b5d375 Compare November 24, 2019 21:56
Jairo Llopis and others added 13 commits November 26, 2019 20:50
@Daemo00
Rename to partner_contact_gender.
cc3dc10
@oca-transbot @Daemo00
OCA Transbot updated translations from Transifex
dc28219
@Daemo00
[9.0] Upgrade Partner Gender module
b52bae6
@hbrunn @Daemo00
[ADD] init hook to set gender based on titles
afa885b
@leemannd @Daemo00
Fix multiple tabs "contact information"
1de6c02
@Daemo00
[MIG] partner_contact_gender: Migration to 11.0
90c88d3
@oca-travis @Daemo00
[UPD] Update partner_contact_gender.pot
5006598
@mvrodriguez @Daemo00
Translated using Weblate (Spanish)
d01ba83 
Currently translated at 100.0% (5 of 5 strings)

Translation: partner-contact-11.0/partner-contact-11.0-partner_contact_gender
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-partner_contact_gender/es/
@oihane @Daemo00
[MIG] partner_contact_gender: Migration to 12.0
64f23dd
@oca-travis @Daemo00
[UPD] Update partner_contact_gender.pot
73f955a 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_gender
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_gender/

[UPD] README.rst
@hhgabelgaard @Daemo00
Translated using Weblate (Danish)
b7dc258 
Currently translated at 100.0% (5 of 5 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_gender
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_gender/da/
@Daemo00
[MIG] partner_contact_gender: Migration to 13.0
938ed43
@Daemo00
fix pylint warning
8492026 
[W0622(redefined-builtin), TestBaseLocationGeonamesImport.test_import_title] Redefining built-in 'zip'
@Daemo00 Daemo00 force-pushed the 13.0-mig-partner_contact_gender branch from 5b5d375 to 8492026 Compare November 26, 2019 19:50
@ermannognan
Copy link
Contributor

Hi, can you include this module in the official v 13.0 branch? I need for it to complete my application! Thanks.

@Daemo00
Copy link
Contributor Author

Daemo00 commented Nov 27, 2019

Hi @ermannognan, in order to speed up the merge process (that is, having this module in branch 13.0), you can review the module: https://odoo-community.org/page/review

StephanRozendaal
StephanRozendaal approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@StephanRozendaal StephanRozendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending PR is merged.

Code looks good.

NL66278
NL66278 approved these changes Dec 1, 2019
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Dec 2, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-792-by-NL66278-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 2, 2019
@OCA-git-bot
Merge PR #792 into 13.0
8206330 
Signed-off-by NL66278
@OCA-git-bot OCA-git-bot merged commit 8492026 into OCA:13.0 Dec 2, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ffca8b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanRozendaal StephanRozendaal StephanRozendaal approved these changes

@NL66278 NL66278 NL66278 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet