Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] partner company type #801

Merged
merged 15 commits into from
Nov 18, 2019
Merged

[13.0][MIG] partner company type #801

merged 15 commits into from
Nov 18, 2019

Conversation

Laurent-Corron
Copy link

No description provided.

rousseldenis and others added 12 commits November 5, 2019 17:40
@rousseldenis
Add partner_business_entity module
7944cf5
@rousseldenis
partner_company_type: Fix possible translation problem
1942080
@oca-travis
Update partner_company_type.pot
b414d99
Translated using Weblate (Português (Brasil))
b0c4396 
Currently translated at 100,0% (15 of 15 strings)

Translation: partner-contact-10.0/partner-contact-10.0-partner_company_type
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_company_type/pt_BR/
[12.0][MIG] partner company type
3c2d26a
@OCA-git-bot
[UPD] README.rst
27093f2
@oca-travis
[UPD] Update partner_company_type.pot
97b9ebf
@oca-transbot
Update translation files
7d7423d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_company_type
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_company_type/
@max3903
[FIX] partner_company_type: Pylint errors
d710607
@OCA-git-bot
[UPD] README.rst
c45f340
@OCA-git-bot
[UPD] README.rst
4f8515b
Translated using Weblate (Portuguese (Brazil))
3e19bac 
Currently translated at 100.0% (16 of 16 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_company_type
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_company_type/pt_BR/
@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 6, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 6, 2019
Open
47 tasks
lmignon
lmignon suggested changes Nov 7, 2019
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Laurent-Corron for the migration.
Nevertheless can you remove the goup_no_one on the menu to get access to the list of company types. This group prevents members having access to the Configuration menu into contacts to get access to the company types sub menu

partner-contact/partner_company_type/views/res_partner_company_type.xml

Line 52 in a1a1d82

sequence="4" groups="base.group_no_one"/>

@Laurent-Corron
Copy link
Author

@lmignon fixed!

lmignon
lmignon approved these changes Nov 7, 2019
View reviewed changes
Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Laurent-Corron (Functional + code)

lfreeke
lfreeke approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Nov 18, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-801-by-NL66278-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 18, 2019
@OCA-git-bot
Merge PR #801 into 13.0
17241e0 
Signed-off-by NL66278
@OCA-git-bot OCA-git-bot merged commit e7e5b8d into OCA:13.0 Nov 18, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 727e79f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@lfreeke lfreeke lfreeke approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@Laurent-Corron @OCA-git-bot @NL66278 @lmignon @lfreeke @pedrobaeza @rousseldenis @oca-travis @oca-transbot @max3903