[IMP] base_location: Updated to v8 syntax and uses. Added filters in som... #81

alejandrosantana · 2015-01-18T23:43:04Z

...e views. Added two columns in respective tree views.

base_location/partner-contact changes

API

Updated code to v8 API syntax
Moved models to 'models/' folder.
Moved views to 'views/' folder, removed suffix '_views' as redundant (for being now in 'views/').

Views

Added 'currency_id' column to res.country tree view.
Added 'state_id' column to better.zip tree view
Added several filters to views, now you can:
- search a country by its code in country view.
- search by zip, city code, city name, state and country in better_zip view.
- group by state and country in better_zip search view.

Questions

My PEP8/flake8 check throws this false error:
- ./base_location/models/partner.py:28:13: E222 multiple spaces after operator
- But there is only a slash(/) in the field string value, so there is no real operator there.

…some views. Added two columns in respective tree views.

pedrobaeza · 2015-01-18T23:47:57Z

What is the purpose of the currency_id? I think in this module (name base_location), this concept doesn't apply.

pedrobaeza · 2015-01-18T23:48:35Z

base_location/__openerp__.py

- }
+{
+    'name': 'Location management (aka Better ZIP)',
+    'version': '0.3.2',


As this is in new API, you can put 1.0 as a major version

alejandrosantana · 2015-01-19T00:11:46Z

OK, changes in a few minutes.

…van currency_id column on country tree view, enhanced description and manidest, addded README.rst file.

alejandrosantana · 2015-01-20T18:17:39Z

Changes done.
May I ask, why README.rst? (instead of .md).

pedrobaeza · 2015-01-20T18:18:40Z

Because Odoo only parses reStructuredText (although in a .md file), and GitHub will be confused if we put .md.

pedrobaeza · 2015-01-21T12:28:32Z

Can you check Travis?

pedrobaeza · 2015-01-21T12:29:03Z

base_location/__openerp__.py

+        'Alejandro Santana <alejandrosantana@anubia.es>',
+    ],
+    'summary': '''Enhanced zip/npa management system''',
+    'description': '''


You don't need to put now this key as you have README.rst

pedrobaeza · 2015-01-21T12:34:55Z

The convention about view file names is to have the suffix _view.xml, so please rename your files accordingly.

yvaucher · 2015-01-21T13:00:13Z

base_location/views/better_zip.xml

        </search>
      </field>
    </record>
-
+	 


Please, don't add useless spaces

yvaucher · 2015-01-21T13:04:12Z

@pedrobaeza about file name, convention is _view.xml unless it is in view or views directory. So nothing to change here for that.

pedrobaeza · 2015-01-21T13:05:34Z

Not exactly, because inside view/views folder you can also put _menu.xml files. That's why I keep also the _view suffix.

alejandrosantana · 2015-01-21T13:11:43Z

OK, I am doing all changes. Regarding the views naming I will stick to "_view.xml" naming and later on we can discuss what naming should be preferred, all right?

alejandrosantana · 2015-01-21T13:12:56Z

Regarding Travis, there was a trailing space in this module causing flake8 errors. Then, I see some error in another module (first_name).

yvaucher · 2015-01-21T13:13:36Z

@pedrobaeza yep you can also have qweb report in view thus you can add suffix for menu and prefix for report and keep it short with view. No real convention is there thought. In most case you don't even have menu, just views, so I'm for view without suffix.

yvaucher · 2015-01-21T13:15:09Z

@alejandrosantana You might have misread it:

./base_location/__openerp__.py:37:76: W291 trailing whitespace

yvaucher · 2015-01-21T13:15:53Z

base_location/__openerp__.py

+    'summary': '''Enhanced zip/npa management system''',
+    'description': '''
+    This module introduces a better zip/npa management system.
+    It enables zip, city, state and country auto-completion on partners and 


Here is the extra space to remove at EOL

alejandrosantana · 2015-01-21T13:16:35Z

@yvaucher Yes, that's the one causing flake8 to fail. Anyway, that is fixed now. One minute and I push the changes.

…ted fields. Also use @api.one in onchanges. Using now spaces instead of tabs in xml files.

alejandrosantana · 2015-01-21T13:21:14Z

Changes done. Push done. Let's see what Travis has to say.

alejandrosantana · 2015-01-21T13:39:05Z

Seems Travis is failing with tests in 'partner_firstname'.

pedrobaeza · 2015-01-21T13:59:31Z

OK, Travis is unrelated, so please make the rest of the changes. Remove also better_zip symlink, because it's deprecated.

alejandrosantana · 2015-01-21T14:00:42Z

All changes done, except removal of better_zip, which I will do in a minute.

…ase_location.

alejandrosantana · 2015-01-21T14:03:06Z

@pedrobaeza better_zip removed.

pedrobaeza · 2015-01-21T14:07:51Z

Thanks for the changes!

👍

alejandrosantana · 2015-01-21T14:11:49Z

Nice! I liked collaborating! Great way to learn too.
Have to steal some more time for more.

yvaucher · 2015-01-21T14:21:24Z

Error is indeed unrelated thanks

👍

guewen · 2015-01-21T19:33:47Z

base_location/models/partner.py

+    @api.onchange('zip_id')
+    def onchange_zip_id(self):
+        if self.zip_id:
+            bzip = self.zip_id[0]


[0] is useless, bzip = self.zip_id will behave exactly the same

guewen · 2015-01-21T19:34:50Z

1 minor remark, but 👍

alejandrosantana · 2015-01-21T20:31:33Z

@guewen Minor thing, but you are right. Already fixed.

guewen · 2015-01-21T20:56:55Z

Thanks!

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som...

[IMP] base_location: Updated to v8 syntax and uses. Added filters in …

9c82d94

…some views. Added two columns in respective tree views.

pedrobaeza reviewed Jan 18, 2015
View reviewed changes

[FIX] base_contact: Fixed PEP8. [IMP] base_location: Removed non-rele…

ff3c3bd

…van currency_id column on country tree view, enhanced description and manidest, addded README.rst file.

pedrobaeza reviewed Jan 21, 2015
View reviewed changes

yvaucher reviewed Jan 21, 2015
View reviewed changes

base_location/views/better_zip.xml

</search>

</field>

</record>

Copy link

Member

yvaucher Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't add useless spaces

yvaucher added needs fixing 8.0 labels Jan 21, 2015

yvaucher reviewed Jan 21, 2015
View reviewed changes

[FIX] base_location: Fix flake8 error, views naming, removing depreca…

f7f02a6

…ted fields. Also use @api.one in onchanges. Using now spaces instead of tabs in xml files.

pedrobaeza mentioned this pull request Jan 21, 2015

IMP base_location module #63

Closed

[DEL] better_zip: Removed deprecated symlink better_zip pointing to b…

2220fbd

…ase_location.

yvaucher added needs review and removed needs fixing labels Jan 21, 2015

guewen reviewed Jan 21, 2015
View reviewed changes

[FIX] base_location: Removed unnecesary temporary variable.

9724307

guewen added a commit that referenced this pull request Jan 21, 2015

Merge pull request #81 from alejandrosantana/8.0

b6315c6

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som...

guewen merged commit b6315c6 into OCA:8.0 Jan 21, 2015

guewen removed the needs review label Jan 21, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som... #81

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som... #81

alejandrosantana commented Jan 18, 2015

pedrobaeza commented Jan 18, 2015

pedrobaeza Jan 18, 2015

alejandrosantana commented Jan 19, 2015

alejandrosantana commented Jan 20, 2015

pedrobaeza commented Jan 20, 2015

pedrobaeza commented Jan 21, 2015

pedrobaeza Jan 21, 2015

pedrobaeza commented Jan 21, 2015

yvaucher Jan 21, 2015

yvaucher commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

yvaucher commented Jan 21, 2015

yvaucher commented Jan 21, 2015

yvaucher Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

yvaucher commented Jan 21, 2015

guewen Jan 21, 2015

guewen commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

guewen commented Jan 21, 2015

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som... #81

[IMP] base_location: Updated to v8 syntax and uses. Added filters in som... #81

Conversation

alejandrosantana commented Jan 18, 2015

base_location/partner-contact changes

API

Views

Questions

pedrobaeza commented Jan 18, 2015

pedrobaeza Jan 18, 2015

Choose a reason for hiding this comment

alejandrosantana commented Jan 19, 2015

alejandrosantana commented Jan 20, 2015

pedrobaeza commented Jan 20, 2015

pedrobaeza commented Jan 21, 2015

pedrobaeza Jan 21, 2015

Choose a reason for hiding this comment

pedrobaeza commented Jan 21, 2015

yvaucher Jan 21, 2015

Choose a reason for hiding this comment

yvaucher commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

yvaucher commented Jan 21, 2015

yvaucher commented Jan 21, 2015

yvaucher Jan 21, 2015

Choose a reason for hiding this comment

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

pedrobaeza commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

yvaucher commented Jan 21, 2015

guewen Jan 21, 2015

Choose a reason for hiding this comment

guewen commented Jan 21, 2015

alejandrosantana commented Jan 21, 2015

guewen commented Jan 21, 2015