Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] partner_default_sale_discount #842

Merged

Conversation

lbelorgey
Copy link

Standard migration of module partner_default_sale_discount.

@lbelorgey lbelorgey mentioned this pull request Jan 19, 2020
39 tasks
@rousseldenis rousseldenis added this to the 12.0 milestone Jan 20, 2020
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM but would be could to change license lines to https: to make it complete up to date with conventions.

Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the migration!

@lbelorgey lbelorgey force-pushed the 12.0-mig-partner_default_sale_discount branch from 79f8d7b to fde8554 Compare February 7, 2020 15:38
pedrobaeza and others added 3 commits March 6, 2020 11:50
* [ADD] partner_default_sale_discount

Default sales discount per partner
==================================

This module allows to define at partner level a default discount to be applied
on sales orders as the default one. As the field is a company dependent one,
you can configure a different value for the partner for each of your companies.

Configuration
=============

Enabling the use of discounts in Odoo:

* Go to *Sales > Configuration > Settings*
* On the group "Quotations & Sales", select the option "Allow discounts on
  sales order lines" for the "Discount" section.

Setting a default sales discount:

* Then, go to *Sales > Customers*.
* Create or modify a customer.
* Go to "Sales & Purchases" page.
* In the "Sale" section, there's a field called "Default sales discount (%)"
  where you can fill the default discount percentage.
* This value can only be filled at company partners, not for contacts.

Usage
=====

To use this module, you need to:

* Go to Sales > Quotations.
* Create a new quotation.
* Select a partner with a default discount applied.
* Create an order line, and you will see this discount as default in the line.

Known issues / Roadmap
======================

* This module doesn't work with *product_visible_discount*, as it overwrites
  the discount field with its own value.
Squashed commit:

[deb6424] OCA Transbot updated translations from Transifex

[4eee6a2] OCA Transbot updated translations from Transifex

[4805b0c] OCA Transbot updated translations from Transifex
@lbelorgey lbelorgey force-pushed the 12.0-mig-partner_default_sale_discount branch from fde8554 to 4aba93e Compare March 6, 2020 10:50
Copy link
Contributor

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Mar 11, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-842-by-NL66278-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 84c98a5 into OCA:12.0 Mar 11, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 713fd29. Thanks a lot for contributing to OCA. ❤️

@lbelorgey lbelorgey deleted the 12.0-mig-partner_default_sale_discount branch March 11, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants