Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig]-hr_payroll_period #120

Merged
merged 9 commits into from
May 23, 2023
Merged

[15.0][mig]-hr_payroll_period #120

merged 9 commits into from
May 23, 2023

Conversation

JuanyDForgeflow
Copy link

Migration to 15.0

nimarosa and others added 8 commits March 1, 2023 11:23
@nimarosa
[14.0] [ADD] hr_payroll_period
f482352 
[14.0] [ADD] hr_payroll_period: Add mantainers key

[14.0] [ADD] hr_payroll_period: Change manifest category

[14.0] [ADD] hr_payroll_period

[14.0] [ADD] hr_payroll_period

[14.0] [IMP]  hr_payroll_period: Improve views

[14.0] [IMP] hr_payroll_period: Improve views and misc

[14.0] [IMP] hr_payroll_period: Improve views and misc

[14.0] [IMP] hr_payroll_period: Improve views and misc
[UPD] Update hr_payroll_period.pot
e7dc861
@OCA-git-bot
[UPD] README.rst
7900b82
@nimarosa
Added translation using Weblate (Spanish (Argentina))
0178b55
@nimarosa
Translated using Weblate (Spanish (Argentina))
eaf2531 
Currently translated at 84.6% (83 of 98 strings)

Translation: payroll-14.0/payroll-14.0-hr_payroll_period
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-hr_payroll_period/es_AR/
@nimarosa
Translated using Weblate (Spanish)
2721426 
Currently translated at 100.0% (98 of 98 strings)

Translation: payroll-14.0/payroll-14.0-hr_payroll_period
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-hr_payroll_period/es/
@nimarosa
Translated using Weblate (Spanish (Argentina))
bccb0d9 
Currently translated at 100.0% (98 of 98 strings)

Translation: payroll-14.0/payroll-14.0-hr_payroll_period
Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-hr_payroll_period/es_AR/
[IMP]hr_payroll_period: black, isort, prettier
781fd76
@JuanyDForgeflow JuanyDForgeflow mentioned this pull request Mar 1, 2023
Merged
hieulucky111
hieulucky111 suggested changes May 19, 2023
View reviewed changes
hr_payroll_period/models/hr_fiscal_year.py Outdated Show resolved Hide resolved
hr_payroll_period/models/hr_fiscal_year.py Outdated Show resolved Hide resolved
hr_payroll_period/models/hr_fiscal_year.py Show resolved Hide resolved
hr_payroll_period/models/hr_payslip.py Outdated Show resolved Hide resolved
hr_payroll_period/models/hr_payslip_run.py Outdated Show resolved Hide resolved
hr_payroll_period/models/hr_payslip_run.py Outdated Show resolved Hide resolved
hr_payroll_period/models/hr_fiscal_year.py Outdated Show resolved Hide resolved
@JuanyDForgeflow
Copy link
Author

@hieulucky111 please take a look at it again, it's fixed now

MiquelRForgeFlow
MiquelRForgeFlow approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hieulucky111
hieulucky111 approved these changes May 22, 2023
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@nimarosa
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-120-by-nimarosa-bump-nobump, awaiting test results.

@nimarosa
Copy link
Contributor

/ocabot migration hr_payroll_period

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 23, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 23, 2023
Open
6 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#19) has been updated to reference the current pull request.
however, a previous pull request was referenced : #102.
Perhaps you should check that there is no duplicate work.
CC : @nimarosa

@OCA-git-bot OCA-git-bot merged commit ce9cc4c into OCA:15.0 May 23, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3774d11. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-hr_payroll_period branch May 25, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieulucky111 hieulucky111 hieulucky111 approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JuanyDForgeflow @OCA-git-bot @nimarosa @hieulucky111 @MiquelRForgeFlow