Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][MIG] pos_remove_pos_category #148

Merged
merged 4 commits into from
Feb 28, 2017
Merged

[9.0][MIG] pos_remove_pos_category #148

merged 4 commits into from
Feb 28, 2017

Conversation

simahawk
Copy link

@simahawk simahawk commented Jan 23, 2017 •
edited
Loading

No description provided.

leemannd
leemannd reviewed Jan 23, 2017
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use short headers in .py files and s/openerp/odoo/ & s/data// in https://github.com/camptocamp/pos/blob/57cd380dd38bfcbceb166e36799f4f6db168bef1/pos_remove_pos_category/views/pos_view.xml#L3

@simahawk
Copy link
Author

@leemannd better? :)

@simahawk simahawk changed the title [9.0][MIG] pos_remove_pos_category [9.0][MIG][WIP] pos_remove_pos_category Jan 25, 2017
@simahawk simahawk changed the title [9.0][MIG][WIP] pos_remove_pos_category [9.0][MIG] pos_remove_pos_category Jan 25, 2017
@ovnicraft
Copy link
Member

Any updates for this ?

So comment was resolved

leemannd
leemannd approved these changes Feb 13, 2017
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only

@simahawk
Copy link
Author

@legalsylvain any opinion? :)

@legalsylvain
Copy link
Contributor

I'd prefer to let @sylvainc to review this module, as he is the original author. Otherwise, I'll do it but immediately. (too much work for the time being.)
kind regards.

@sylvainc
Copy link

Hello @simahawk,

Sorry for the delay.

LGTM (code review only)

👍

Thanks for your contribution!

@legalsylvain legalsylvain merged commit b3ba988 into OCA:9.0 Feb 28, 2017
@pedrobaeza pedrobaeza mentioned this pull request Feb 28, 2017
Closed
11 tasks
mourad-ehm pushed a commit to akretion/pos that referenced this pull request Mar 13, 2017
@simahawk @mourad-ehm
pos_remove_pos_category (OCA#148)
87593e6 
* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category
legalsylvain pushed a commit that referenced this pull request May 29, 2017
@simahawk @legalsylvain
pos_remove_pos_category (#148)
bcf5b75 
* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category
hparfr added a commit to akretion/pos that referenced this pull request Apr 27, 2018
@hparfr
10.0 mig product template (#7)
deb2bf5 
* [ADD] setup.py

* [UPD] addons table in README.md

* [FIX] travis: Update travis file to new standard
* Add new matrix
* Add transifex support
* Switch coveralls to travis_after_tests_success
* Move pip requirements to requirements.txt

* OCA Transbot updated translations from Transifex

* OCA Transbot updated translations from Transifex

* [UPD] addons table in README.md

* [UPD] addons table in README.md

* Make pos_customer_display odoo9 compatible

* Fix version number of pos_customer_display

* Port pos_customer_display to v10

Remove the "Show total to customer" button, which is not need given the new user interface of the POS: the big "Payment" button has this role now.
Add README.rst

* Display relevant info on LCD when Qty/price/discount is forced via the buttons of the POS frontend

* Remove comment

* [UPD] addons table in README.md

* [ADD] setup.py

* new module pos_margin

* [PORT] 10.0 pos_margin

* [UPD] addons table in README.md

* [ADD] setup.py

* OCA Transbot updated translations from Transifex

* pos_remove_pos_category (OCA#148)

* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category

* OCA Transbot updated translations from Transifex

* [MIG] pos_remove_pos_category: Migrated to 10.0

* [FIX] static javascript assets

* [UPD] addons table in README.md

* [ADD] setup.py

* OCA Transbot updated translations from Transifex

* [ADD] pos_loyalty: loyalty programs for POS (OCA#185)

* [ADD] pos_loyalty: loyalty programs for POS

* [FIX] Limit to one discount reward per order

* [FIX] Remove unused variables and returns

* [IMP] Refactoring rules loading

* [UPD] addons table in README.md

* [ADD] setup.py

* OCA Transbot updated translations from Transifex

* OCA Transbot updated translations from Transifex

* [REM] remove pos_remove_pos_category Fix : OCA#200

* [UPD] addons table in README.md

* Revert "[REM] remove pos_remove_pos_category Fix : OCA#200"

This reverts commit 5825f0f.

* [FIX] avoid monkey patch and error on foreign key constraint

* [UPD] addons table in README.md

* pos_remove_pos_category: inherit the proper view of product.template

* [fix] compability between pos_customer_display and pos_pricelist (OCA#210)

* [fix] compability between pos_customer_display and pos_pricelist

* [UPD] addons table in README.md

* [ADD] PoS session pay invoice module

* [UPD] addons table in README.md

* [add] pos_default_payment_method

* fixup! [add] pos_default_payment_method

* [UPD] addons table in README.md

* [ADD] setup.py

* [FIX] Fix pos_customer_display with Floors in Restaurant

* Add mobule pos_backend_partner

* Update readme

Fix link to github

* Improve readme and manifest

* Add OCA dependencies for allowing tests on a not merged PR

* Fix readme, fix indent, fix bug when choosing a customer in payment pane.

* Add screenshots

* Fix screenshot path

* Update readme

* Hide button when not opened by pos

* [10.0] Remove hw_customer_display and hw_telium_payment_terminal (OCA#231)

* Remove hw_customer_display and hw_telium_payment_terminal

POSbox image runs Odoo v8, so we should maintain hw_* modules only in the 8.0 branch for the moment.

* Update requirements.txt following removal of hw_* modules

* [UPD] addons table in README.md

* update oca_dependencies

* update readme

* Update __init__

* update manifest

* update __init

* fix copyright

* fix copyright2

* update roadmap

* OCA Transbot updated translations from Transifex

* Add pos_backend_communication module

* Update readme

Fix github link

* Update readme

* Update readme.rst

* Update common.js

Fix typo

* Update readme

* [UPD] addons table in README.md

* [ADD] setup.py

* [ADD] module pos_price_to_weight (OCA#171)

* [ADD] module pos_price_to_weight

* [FIX] jslint / pylint / flake8 issues

* OCA Transbot updated translations from Transifex

* [MIG] pos_price_to_weight: Migration to 10.0

* [FIX] in v10, we can add value to selection fieldw

* [UPD] addons table in README.md

* [ADD] setup.py

* [FIX] website URI

* [FIX] website URI

* remove duplicated act_windows

* [ADD] new module pos_quick_logout (OCA#116)

* OCA Transbot updated translations from Transifex

* OCA Transbot updated translations from Transifex

* [MIG] pos_quick_logout: Migration to 10.0

[FIX] Fix Travis

[FIX] Fix Licence

[FIX] rename pos_quick_logout.py to pos_config.py

[FIX] Travis

[FIX] fix javascript syntax + __manifest__ typo

[FIX] fix python syntax

[FIX] rename pos_quick_logout_view.xml to pos_config_view.xml

[FIX] Travis : remove unused imports

* [IMP] add autologout to pos_quick_logout

[IMP] it's better to launch timeout fonction with start

* [UPD] addons table in README.md

* [ADD] setup.py

* [FIX] remove outdated dependencies

* OCA Transbot updated translations from Transifex

* [ADD] new module pos_timeout

* [UPD] addons table in README.md

* [ADD] setup.py

* [FIX] fixes currencies with decimals <>2

* [MIG] pos_pricelist: Migrate to v10 by backporting from v11 (OCA#247)

This module included previously support for taxes and pricelists.

Taxes are now included in upstream Odoo v10, so that feature is removed.

The pricelist feature, however, is supported in upstream Odoo v11. Thus, to ease the migration path, that functionality has been scalpel-backported from there.

This also means a great diff between previous OCA-only code and current Odoo-backport-only code, but with the advantage that the end user gets exactly the behavior that he would have when updating to v11.

Since most of the code has been copied from Odoo, the addon now has to become LGPL, and Odoo has been added as an author.

* [FIX] pos_pricelist: Fix language file

* [UPD] addons table in README.md

* [ADD] setup.py

* [FIX] pos_pricelist: Use lower-version date comparison

The removed function was introduced in momentjs in version 2.11.0, but Odoo 10.0 ships 2.8.1, so I'm using a different comparison system here that should yield the same results without exceptions.

* [UPD] addons table in README.md

* OCA Transbot updated translations from Transifex

* [10.0][ADD] pos_lot_selection: New module (OCA#256)

* [UPD] addons table in README.md

* [ADD] setup.py

* [ADD] pos_stock_picking_invoice_link: New Module

* Add module pos_default_empty_image

Big perf improvement for loading POS if you have thousand of products
without image

* Limit lines to < 80 chars

* No new line at end of file

* Add missing credits

* description file;

* Fix line length in readme

Remove __openerp.py_.description
Remove _name
Remove unneeded contents in init

* [PORT] pos_default_empty_image courtesy @invitu

* [IMP] pos_default_empty_image courtesy @invitu

* [FIX] set has_image on 'product.product' model
[IMP] make has_image stored
[REF] improve description and add screenshots
[REF] OCA convention

* [FIX] wording + remove useless JS code

* [REF] cosmetic points

* Fix readme remarks

* [UPD] addons table in README.md

* [ADD] setup.py

* [UPD] addons table in README.md

* [ADD] setup.py

* Updated pos_product_template addon to Odoo 9

* Added Spanish translation to pos_product_template (es.po)

* [FIX] Change the version number to 9 and make module installable.

* Add readme, update manifest,

switch to short copyright headers

* Some refactorings

* Refactore db

* Refactore set_product_list

* Remove comments

* Add pos_fix_search_limit module

* add pos_fix_search_limit in manifest

* [UPD] addons table in README.md

* [ADD] setup.py

* Make the ppt inheritable
sebastienbeau pushed a commit to akretion/pos that referenced this pull request Oct 12, 2020
@simahawk @sebastienbeau
pos_remove_pos_category (OCA#148)
5eb582f 
* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category
sebastienbeau pushed a commit to akretion/pos that referenced this pull request Dec 18, 2020
@simahawk @sebastienbeau
pos_remove_pos_category (OCA#148)
f2cc62c 
* migrate to v9 and add italian translation

* short headers

* migrate JS

* [fix] be defensive: do not assume we have a product category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simahawk @ovnicraft @legalsylvain @sylvainc @leemannd