[7.0] pos_localstorage #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // List of product attributes that the POS uses. | ||
| var productAttributeList = ['name', 'list_price','price','pos_categ_id', 'taxes_id', 'ean13', 'default_code', 'variants', | ||
| 'to_weight', 'uom_id', 'uos_id', 'uos_coeff', 'mes_type', 'description_sale', 'description']; | ||
|
|
There was a problem hiding this comment.
Could you set searchGracePeriod and productAttributeList as model vars to allow other modules to overload more easely ?
|
Up ! @OSguard what about our last comments ? |
|
I guess this PR is ready to be merged. @OSguard could you give me you feedback please? cc @jcarlosmontoya @JGarcia-Panach your review here could be fantastic please! Thanks! |
|
Hi @OSguard please if you could review this PR and fix travis we will review it to get it merged! Thanks! 😄 |
|
Closing this PR, due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module that stores the product in browser localstorge for faster loading of pos