New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] [ADD] Reset search after click on product. #443
Conversation
@robinkeunen would you have time to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is good, minor remarks are about the readme and the manifest.
@robinkeunen would you happen to know someone willing to do a second review on this? Thx! |
Maybe @legalsylvain |
@ivantodorovich would you have time to take a look at this? It's fairly simple but could save a significant amount of time in our "épicerie participative". |
@ivantodorovich Thank you! |
/ocabot merge |
Sorry @Fkawala you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@legalsylvain could you /ocabot merge? Thanks! |
Sorry @Fkawala you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
This PR has the |
Hi @Fkawala If you want you can add you as maintainer of this module. https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L13 You'll have then more rights, regarding this module. (merging Fix PR, migrate module in 12.0, ...) the counterpart is to be reactive, when users have problem with the modules. (at least answer to the question ; fixing is another story) |
Thank you @legalsylvain, I did not know that. I'm ready to be reactive on question answering and even bug fixing. I'll do that for that module as well as the #447 one if it is ok with you. |
OK, nice !
There no problem apriori to add your self as maintainer if you're the original author. You just have to make a new PR, with just the key maintainers against the branch 9.0, in the module |
/ocabot merge |
Hey, thanks for contributing! Proceeding to merge this for you. |
I'm the original author so I'll proceed that way thank you again for the detailed explanation :) |
Congratulations, your PR was merged at ea405b1. Thanks a lot for contributing to OCA. ❤️ |
The POS search workflow is to type-in the product name until there is only one product left to be selected. Then the user will select the product by typing on the "enter" key. To select a product clears the search. This workflow is very efficient but it requires training.
This add-on complete the POS search workflow for beginners. This add-on enables users to search and narrow down the product selection to a handful of products. The user can then use the mouse and click on the product to select. To click on the product clears search. The default workflow is still usable for trained users.
This new workflow is deemed less efficient but has proven to help beginners.