Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [ADD] Reset search after click on product. #443

Merged
merged 8 commits into from Feb 18, 2020

Conversation

Fkawala
Copy link
Contributor

@Fkawala Fkawala commented Jan 20, 2020

The POS search workflow is to type-in the product name until there is only one product left to be selected. Then the user will select the product by typing on the "enter" key. To select a product clears the search. This workflow is very efficient but it requires training.

This add-on complete the POS search workflow for beginners. This add-on enables users to search and narrow down the product selection to a handful of products. The user can then use the mouse and click on the product to select. To click on the product clears search. The default workflow is still usable for trained users.

This new workflow is deemed less efficient but has proven to help beginners.

@Fkawala
Copy link
Contributor Author

Fkawala commented Jan 22, 2020

@robinkeunen would you have time to review this?

Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good, minor remarks are about the readme and the manifest.

pos_reset_search/__openerp__.py Outdated Show resolved Hide resolved
pos_reset_search/README.rst Outdated Show resolved Hide resolved
pos_reset_search/README.rst Outdated Show resolved Hide resolved
@Fkawala Fkawala changed the title Reset search after click on product. [9.0] [ADD] Reset search after click on product. Jan 27, 2020
@Fkawala
Copy link
Contributor Author

Fkawala commented Jan 27, 2020

@robinkeunen would you happen to know someone willing to do a second review on this? Thx!

@robinkeunen
Copy link

Maybe @legalsylvain

@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

@ivantodorovich would you have time to take a look at this? It's fairly simple but could save a significant amount of time in our "épicerie participative".

@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

@ivantodorovich Thank you!

@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Sorry @Fkawala you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

@legalsylvain could you /ocabot merge? Thanks!

@OCA-git-bot
Copy link
Contributor

Sorry @Fkawala you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

Hi @Fkawala If you want you can add you as maintainer of this module.

https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L13

You'll have then more rights, regarding this module. (merging Fix PR, migrate module in 12.0, ...)

the counterpart is to be reactive, when users have problem with the modules. (at least answer to the question ; fixing is another story)
Do you want ?

@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

Thank you @legalsylvain, I did not know that. I'm ready to be reactive on question answering and even bug fixing. I'll do that for that module as well as the #447 one if it is ok with you.

@legalsylvain
Copy link
Contributor

Thank you @legalsylvain, I did not know that. I'm ready to be reactive on question answering and even bug fixing.

OK, nice !

I'll do that for that module as well as the #447 one if it is ok with you.

There no problem apriori to add your self as maintainer if you're the original author. You just have to make a new PR, with just the key maintainers against the branch 9.0, in the module pos_barcode_tare
If you are not the original author, better to ask to the author(s) if he / they are agree.

@legalsylvain
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 9.0-ocabot-merge-pr-443-by-legalsylvain-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 18, 2020
Signed-off-by legalsylvain
@Fkawala
Copy link
Contributor Author

Fkawala commented Feb 18, 2020

There no problem apriori to add your self as maintainer if you're the original author. You just have to make a new PR, with just the key maintainers against the branch 9.0, in the module pos_barcode_tare If you are not the original author, better to ask to the author(s) if he / they are agree

I'm the original author so I'll proceed that way thank you again for the detailed explanation :)

@OCA-git-bot OCA-git-bot merged commit 7a5c747 into OCA:9.0 Feb 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ea405b1. Thanks a lot for contributing to OCA. ❤️

@Fkawala Fkawala deleted the 9.0-reset-search branch February 18, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants