Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] FIX pos_partner_firstname allowing non admin users to get partner_names_order from POS frontend #445

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 21, 2020

Otherwise they would get access error on ir.config_parameter

Steps:

  • Create a user POS manager without administration rights
  • Using that user, open POS frontend

…es_order from POS frontend

Otherwise they would get access error on ir.config_parameter

Steps:

 - Create a user POS manager without administration rights
 - Using that user, open POS frontend
@OCA-git-bot
Copy link
Contributor

Hi @robyf70,
some modules you are maintaining are being modified, check this out!

Copy link

@mrcast mrcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok.
Thanks

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch.

/ocabot merge minor

@eLBati
Copy link
Member Author

eLBati commented Jan 21, 2020

I think you need to run /ocabot merge minor in a separate message.
Thanks

@OCA-git-bot
Copy link
Contributor

Sorry @eLBati you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@robyf70
Copy link
Contributor

robyf70 commented Jan 21, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-445-by-robyf70-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 21, 2020
Signed-off-by robyf70
@OCA-git-bot OCA-git-bot merged commit 315a406 into OCA:12.0 Jan 21, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d6f7ee8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants