Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] pos_customer_required #450

Merged
merged 5 commits into from Feb 11, 2020
Merged

[12.0][MIG] pos_customer_required #450

merged 5 commits into from Feb 11, 2020

Conversation

ivantodorovich
Copy link
Contributor

No description provided.

@ivantodorovich

This comment has been minimized.

Sign in to view
@ivantodorovich ivantodorovich force-pushed the 12.0-mig-pos_customer_required branch 5 times, most recently from 1efaac6 to 35f8922 Compare January 31, 2020 13:16
legalsylvain
legalsylvain approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review & runbot test.

works as expected. Thanks !

MeetKD
MeetKD suggested changes Feb 2, 2020
View reviewed changes
pos_customer_required/__manifest__.py Outdated Show resolved Hide resolved
@legalsylvain
Copy link
Contributor

@MeetKD : could you update your review ?

thanks !

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-450-by-legalsylvain-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 11, 2020
@OCA-git-bot
Merge PR #450 into 12.0
22f38af 
Signed-off-by legalsylvain
@OCA-git-bot OCA-git-bot merged commit b81fa66 into OCA:12.0 Feb 11, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 25ec4f4. Thanks a lot for contributing to OCA. ❤️

@ivantodorovich ivantodorovich deleted the 12.0-mig-pos_customer_required branch May 6, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@MeetKD MeetKD MeetKD approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ivantodorovich @legalsylvain @OCA-git-bot @MeetKD @oca-transbot