[add]pos product category button with image #47

jcarlosmontoya · 2015-08-25T12:21:12Z

When installing this module, images of the product categories at the POS buttons are no longer displayed.

TODO : widgets.js update from odoo/addons/point_of_sale/static/src/js

Method (line 459):

get_image_url: function(category){
//original line
//return window.location.origin + '/web/binary/image?model=pos.category&field=image_medium&id='+category.id;
//actual line
return window.location.origin + '/web/binary/image?model=product.category&field=image_medium&id='+category.id;
}

oca-clabot · 2015-08-25T12:21:15Z

Hey @cellsnake, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@cellsnake (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

legalsylvain · 2015-08-25T12:30:50Z

pos_remove_pos_category/product.py

@@ -44,12 +44,23 @@ def write(self, vals):
 class ProductCategory(models.Model):
    _inherit = 'product.category'

+    image = fields.Binary(help='Show Image Category in Form View')
+    image_medium = fields.Binary(help='Show image category button in POS')


Hi,

don't you forgot compute=''_save_image_medium" ?

I think _save_image_medium is more the inverse method than the compute one.

Hello , I tried , but did not have the desired results , so I chose to use @api.constrains

./pos_remove_pos_category/product.py:55:1: W293 blank line contains whitespace ./pos_remove_pos_category/product.py:60:20: F821 undefined name 'tools'

image_medium with inverse parameter updated method _save_image_medium

in inverse _save_image_medium method - add class css and size 100px image in product category form view

jcarlosmontoya · 2015-08-25T18:01:47Z

i need help about coveralls, What does it mean?
Thank you

pedrobaeza · 2015-08-25T18:03:41Z

It means that the part of the code that is covered by tests is lower, but there's not too much impact.

jcarlosmontoya · 2015-08-25T18:06:36Z

Thanks @pedrobaeza

jcarlosmontoya · 2015-08-26T10:29:34Z

Hi
Well, we have images in product category,
Now, for display images in product categories buttons (POS), it needs change model (product.category by pos.category ) in widgets.js (method get_image_url, line 460) from point_of_sale module.
¿How i can do it without touching directly this .js?
¿Someone can help me please?

pedrobaeza · 2015-08-26T10:38:58Z

You have to do JavaScript inheritance, but this something you have to learn by your own

jcarlosmontoya · 2015-08-26T17:55:54Z

thanks @pedrobaeza, come soon i'll update, this take a time, but i'll do it ;)

…th_image-1' into cellsnake-pos_category_button_with_image-1

This file replace src attribute original script POS

legalsylvain · 2015-08-28T12:00:59Z

.idea/codeStyleSettings.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>


Could you remove this file ?

*Override javascript method original POS (get_image_url)

…th_image-1' into cellsnake-pos_category_button_with_image-1

jcarlosmontoya · 2015-08-30T16:08:49Z

do i need to do something else?

for image_medium

[FIX] pos_pricelist does not include price_extra (product variant)

legalsylvain · 2015-09-14T07:02:20Z

.gitignore

@@ -51,3 +51,6 @@ docs/_build/

 # PyBuilder
 target/
+
+# pycharm projects files
+.idea


could you remove this useless lines. (useless for OCA community, maybe not for you...)

legalsylvain · 2015-09-14T07:02:43Z

Is it still WIP ? or does this PR need review ?

legalsylvain · 2015-09-14T07:03:59Z

pos_pricelist/static/src/js/models.js

+            if(product['price_extra'] > 0.0){
+                price += product['price_extra']
+            }
+


i don't understand why you change this file. I guess it is out of the scope of this PR.
regards;

Sorry for these changes, I meant them for another PR but I merged with this one. My mistake.
I have already deleted them.

jcarlosmontoya · 2015-09-14T07:47:23Z

Hello @legalsylvain you can change status to "need review".
Thanks.

legalsylvain · 2015-09-14T08:06:36Z

LGTM. Code review no test. 👍
Thanks for you contribution.
@sylvainc , could you take a look on this PR that improves your module ?

sylvainc · 2015-09-14T19:17:59Z

@legalsylvain, sure.

👍 (code review)

@cellsnake , Thanks for your contribution.

…ith_image-1 [add]pos product category button with image

legalsylvain · 2015-09-14T19:46:31Z

thanks. Merged.

jcarlosmontoya · 2015-09-15T07:15:07Z

Thanks to you @legalsylvain, @sylvainc, @pedrobaeza.
It has been my first contribution, i hope first of many ;)
regards.

jcarlosmontoya added 2 commits August 25, 2015 13:23

Update product.py

b0af23a

Update pos_category.xml

5274a9e

jcarlosmontoya changed the title ~~pos product category button with image~~ [add]pos product category button with image Aug 25, 2015

legalsylvain reviewed Aug 25, 2015
View reviewed changes

legalsylvain added the work in progress label Aug 25, 2015

legalsylvain added this to the 8.0 milestone Aug 25, 2015

jcarlosmontoya added 3 commits August 25, 2015 16:42

updates for:

c892973

./pos_remove_pos_category/product.py:55:1: W293 blank line contains whitespace ./pos_remove_pos_category/product.py:60:20: F821 undefined name 'tools'

updates for:

847a3c5

image_medium with inverse parameter updated method _save_image_medium

- change self.image by record.image

f5318e6

in inverse _save_image_medium method - add class css and size 100px image in product category form view

jcarlosmontoya added 2 commits August 25, 2015 20:25

update por bad definition inverse method in field image_medium

e53353d

update for bad definition inverse method in field image_medium

5888514

jcarlosmontoya added 3 commits August 27, 2015 07:44

update js file POS

a8b47f6

Merge remote-tracking branch 'origin/cellsnake-pos_category_button_wi…

05ff746

…th_image-1' into cellsnake-pos_category_button_with_image-1

add widgets2.js file

8e5b4fb

This file replace src attribute original script POS

legalsylvain reviewed Aug 28, 2015
View reviewed changes

.idea/codeStyleSettings.xml

@@ -0,0 +1,13 @@

<?xml version="1.0" encoding="UTF-8"?>

Copy link

Contributor

legalsylvain Aug 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file ?

jcarlosmontoya added 6 commits August 29, 2015 23:32

Update .gitignore

87f4868

Update .gitignore

468da47

Update .gitignore

9bf7054

*Modify XML view (style image field)

e6fcf09

*Override javascript method original POS (get_image_url)

Merge remote-tracking branch 'origin/cellsnake-pos_category_button_wi…

edc44ed

…th_image-1' into cellsnake-pos_category_button_with_image-1

remove .idea files

785b42c

update _get_image, _set_image

66200b7

for image_medium

jcarlosmontoya added 3 commits September 2, 2015 08:59

Fixed PEP8 warning: line too long

be2689f

Update models.js

f8068a9

Merge pull request #3 from cellsnake/pos_pricelist_with_price_extra

244a808

[FIX] pos_pricelist does not include price_extra (product variant)

legalsylvain reviewed Sep 14, 2015
View reviewed changes

legalsylvain mentioned this pull request Sep 14, 2015

pos_remove_pos_category #46

Closed

legalsylvain reviewed Sep 14, 2015
View reviewed changes

jcarlosmontoya added 2 commits September 14, 2015 09:29

Update models.js

2459a32

[FIX] remove useless lines

d6988d7

legalsylvain added needs review and removed work in progress labels Sep 14, 2015

legalsylvain added a commit that referenced this pull request Sep 14, 2015

Merge pull request #47 from cellsnake/cellsnake-pos_category_button_w…

8c95179

…ith_image-1 [add]pos product category button with image

legalsylvain merged commit 8c95179 into OCA:8.0 Sep 14, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[add]pos product category button with image #47

[add]pos product category button with image #47

jcarlosmontoya commented Aug 25, 2015

oca-clabot commented Aug 25, 2015

legalsylvain Aug 25, 2015

pedrobaeza Aug 25, 2015

jcarlosmontoya Aug 25, 2015

jcarlosmontoya commented Aug 25, 2015

pedrobaeza commented Aug 25, 2015

jcarlosmontoya commented Aug 25, 2015

jcarlosmontoya commented Aug 26, 2015

pedrobaeza commented Aug 26, 2015

jcarlosmontoya commented Aug 26, 2015

legalsylvain Aug 28, 2015

jcarlosmontoya commented Aug 30, 2015

legalsylvain Sep 14, 2015

legalsylvain commented Sep 14, 2015

legalsylvain Sep 14, 2015

jcarlosmontoya Sep 14, 2015

jcarlosmontoya commented Sep 14, 2015

legalsylvain commented Sep 14, 2015

sylvainc commented Sep 14, 2015

legalsylvain commented Sep 14, 2015

jcarlosmontoya commented Sep 15, 2015

[add]pos product category button with image #47

[add]pos product category button with image #47

Conversation

jcarlosmontoya commented Aug 25, 2015

oca-clabot commented Aug 25, 2015

legalsylvain Aug 25, 2015

Choose a reason for hiding this comment

pedrobaeza Aug 25, 2015

Choose a reason for hiding this comment

jcarlosmontoya Aug 25, 2015

Choose a reason for hiding this comment

jcarlosmontoya commented Aug 25, 2015

pedrobaeza commented Aug 25, 2015

jcarlosmontoya commented Aug 25, 2015

jcarlosmontoya commented Aug 26, 2015

pedrobaeza commented Aug 26, 2015

jcarlosmontoya commented Aug 26, 2015

legalsylvain Aug 28, 2015

Choose a reason for hiding this comment

jcarlosmontoya commented Aug 30, 2015

legalsylvain Sep 14, 2015

Choose a reason for hiding this comment

legalsylvain commented Sep 14, 2015

legalsylvain Sep 14, 2015

Choose a reason for hiding this comment

jcarlosmontoya Sep 14, 2015

Choose a reason for hiding this comment

jcarlosmontoya commented Sep 14, 2015

legalsylvain commented Sep 14, 2015

sylvainc commented Sep 14, 2015

legalsylvain commented Sep 14, 2015

jcarlosmontoya commented Sep 15, 2015