[12.0][MIG] pos_tare_generate_barcode #527

Fkawala · 2020-08-27T14:43:39Z

This PR contains the refactorized migration of the tare barcode generator. This work follows on PR #491 as decided by @legalsylvain and myself here #436 and there #447. This new add-on depends on pos_tare (PR #491).

This PR adds a new screen to the POS. The new screen enables to web-print barcode labels of tare values. The tare value is measured using the POS scale. A capture of the new screen below (no change since v9.0 / PR #447).

cc. @houssine78 @vvrossem

OCA-git-bot · 2020-08-27T14:43:44Z

Hi @legalsylvain, @Fkawala,
some modules you are maintaining are being modified, check this out!

legalsylvain

Hi @Fkawala. Just tested on runbot.

when I click on the button, and if the setting is not correctly set, you have loop on the error, and cannot go out of the screen.

(quick review only.)

pos_tare/i18n/fr_CH.po

Fkawala · 2020-08-31T09:17:31Z

Hi @Fkawala. Just tested on runbot.

when I click on the button, and if the setting is not correctly set, you have loop on the error, and cannot go out of the screen.

(quick review only.)

Hi @legalsylvain,

This is a known problem/bug of the POS debug tool. The fake scale sends weight measures in an unexisting UOM "Kg", whereas the POS weight reference UOM is "kg" in lowercase. I'll fix the error loop problem.

Best regards,
François

ps. thank you for your note regarding the translation!

Fkawala · 2020-11-03T14:28:29Z

Hey, @remytms would you have 5 minutes to review that? Sylvain was OK with this PR, aside from the looping error that is now fixed. Cheers, François

houssine78 · 2020-11-09T09:46:30Z

@Fkawala you probably wanted to ping @vvrossem on this PR for review.

houssine78 · 2020-11-09T09:50:48Z

pos_tare_generate_barcode/static/src/xml/pos_tare_generate_barcode.xml

+                <div class="centered-content">
+                    <div class="pos-tare-label-container"></div>
+                    <div class="pos-directions-for-user">
+                        Set the pot on the scale and check the weight above


I would rather use container instead of pot.

I can change and I do not really care, "container" is more generic whereas "pot" is more specific to food/cooking.

houssine78 · 2020-11-09T09:54:29Z

pos_tare_generate_barcode/static/src/xml/pos_tare_generate_barcode.xml

+            <div class="pos-tare-paper">
+                <div class="pos-tare-label">
+                    <img t-att-src="'/report/barcode/EAN13/' + widget.get_barcode_data()" />
+                    <span class="caption">tare = <t t-esc="widget.get_tare_weight()" />kg</span>


kg is hard coded.

Potential issue would be that the tare is on g and not kg. Any way to have uom if the tare configured somewhere ?

second point here is that it limits the use of this module on the kg metric system.

I see that my proposition could to some uom conversion between the tare of the container and the uom of the contained product (not sure of that).

I agree to go ahead without change if you add a section explaining the limitation in the issue/limitation of the readme

ok no issue with conversion, I just read the js code... and saw that you use the uom returned by the scale which is gr for our metric system. only limitation here is it doesn't support UK/US metric system. I'm fine with it !

Fkawala · 2020-11-09T10:16:37Z

pos_tare_generate_barcode/static/src/js/screens.js

+        },
+        set_tare_weight: function (scale_measure) {
+            var weight = scale_measure.weight;
+            var measure_unit = this.pos.units.filter(


@houssine78 We pick up the scale UOM from there. A scale using the Imperial scale would not be a problem there as long as the UOM exists.

Fkawala · 2020-11-09T10:18:44Z

pos_tare_generate_barcode/static/src/js/screens.js

+            if (weight > 0) {
+                var tare_uom = this.pos.config.iface_tare_uom_id[0];
+                var tare_unit = this.pos.units_by_id[tare_uom];
+                this.weight_in_tare_unit = convert_mass(weight,


@houssine78 The tare UOM is a parameter of the POS. Here we convert the weight expressed in the scale's UOM into the parameterized UOM.

Fkawala · 2020-11-09T10:32:11Z

pos_tare_generate_barcode/static/src/js/screens.js

+            }
+            return this.weight_in_tare_unit;
+        },
+        barcode_data: function (weight) {


@houssine78 Here we might have a problem b/c we only consider weight to be in the international standard. We can not store the UOM in the label. We do not want the old labels to become obsolete if the user changes the UOM configuration. Hence we should stick to international standard mass units but fix the display to be in the configured UOM. The current solution would probably break with the Imperial scale. I'll try to propose a fix.

…igured UOM.

Fkawala · 2020-11-10T16:17:01Z

@houssine78 this solves the point you raised about UOM used in the barcode label. @vvrossem Could you please have a look? Thank you!

Fkawala · 2020-11-11T07:35:01Z

@legalsylvain Besides fixing the tare barcode UOM problem, I introduced an additional parameter in the pos_tare module. This parameter enables users to configure if they want to display the tare input field on the scale screen.

The rationale supporting this parameter is as follows. In our shop, we use Adam scales. Those scales do not feature a reset signal, hence odoo needs to reset the weight after <x> seconds to avoid having the operator ordering twice the same weight for two different products. A consequence of odoo resetting the weight after <x> seconds is that our cooperators do not have enough time to use the tare input field on the scale screen before reset happens. One could argue that we should increase <x> but that'll increase the risk of ordering with the wrong weight.

Therefore, to reduce the cognitive load of the operator using the scale screen, we need to hide the input tare field (until we have better scales)

I hope all that is clear. Let me know if not.

legalsylvain

partial review regarding pos_tare module.

pos_tare/models/pos_config.py

legalsylvain · 2020-11-20T12:00:53Z

pos_tare/static/src/js/screens.js

+                var tare_unit = this.pos.units_by_id[tare_uom];
+                var kilogram_uom = this.pos.units.filter(
+                    function (u) {
+                        return u.name === "kg";


sorry. I still don't understand why there are hardcoded text regarding uom in this module. there is no way to have something more modular ? if it's not possible, do you think you could write a section in the ROADMAP section, to mention to do it (maybe when odoo PoS will be refactored...)

Assume you do not hard code this UOM (the one that is used to encode the tare barcode labels). Let's say this UOM is configured to be kilogram. Now print a tare label with 1 unit of UOM, that's one kilogram. Assume the user changes the configuration for this UOM and selects "metric ton". Afterwards one scans the old tare barcode label, she'll get a tare of one metric ton instead of the correct weight of the container that is one kilogram. If you have a better solution than hard coding, I'm happy to change that. Hope this is clear enough.

@legalsylvain What's your opinion on that? Are we all good?

Sorry. Back on that point. I was fully busy the last monthes.

I think " Assume the user changes the configuration for this UOM and selects "metric ton" can not occure.

I tested your Use case with demo data in V12 :

select the product with kilogram unit (Cable Management Box) (stock.product_cable_management_box)

change the quantity (70kg in hand).

select the uom kg (uom.product_uom_kgm)

try to change uom.

You'll have this errors.

My opinion is that odoo doesn't handle that use case. (that is quite hard to handle, I think). so, you should not have to handle that use case in a OCA module, if Odoo core module doesn't allow it.
It will make the code simpler.
Dont you think ?

vvrossem

Thank your work on this module :)
My apologies for the very late review. Here are some remarks.

the duration of your proxy_queue might create issues on the scale software-side
In standard POS, Odoo implements set_weight() (in ScaleScreenWidget) as:

    set_weight: function(weight){
        this.weight = weight;
        this.$('.weight').text(this.get_product_weight_string());
        this.$('.computed-price').text(this.get_computed_price_string());
    },

where get_product_weight_string() returns a defaultstr (e.g. 0.000 Kg) in specific cases

If not already done, I think set_tare_weight() could use the same idea:

weight should be what the scale returns
get_tare_weight_string() should return a default value in case of missing UoM

vvrossem · 2021-03-08T14:34:24Z

pos_tare_generate_barcode/static/src/js/screens.js

+                        self.pos.proxy_queue.clear();
+                    }
+                });
+            }, {duration:150, repeat: true});


There must be at least a 200-ms delay between commands to allow for processing data response time at the scale.

150 ms might be too low if, on the scale software-side, no protocol.commandDelay is used between weight readings

vvrossem · 2021-03-08T15:08:20Z

pos_tare_generate_barcode/static/src/js/screens.js

+                }
+            });
+        },
+        render_receipt: function () {


a detail, but if you render PosTareLabel, you can name your function render_label

vvrossem · 2021-03-08T15:10:02Z

pos_tare_generate_barcode/static/src/xml/pos_tare_generate_barcode.xml

+        <div class="pos-center-align">
+            <div class="pos-tare-paper">
+                <div class="pos-tare-label">
+                    <img t-att-src="'/report/barcode/EAN13/' + widget.get_barcode_data()" />


TIL you can generate barcode that way 🎉

github-actions · 2021-08-22T12:29:57Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Fkawala added 2 commits August 26, 2020 22:12

French translation for the pos_tare addon.

1db7df0

pos tare generate barcode has its own addon now.

ba18a7f

legalsylvain requested changes Aug 31, 2020

View reviewed changes

pos_tare/i18n/fr_CH.po Show resolved Hide resolved

Fkawala added 2 commits November 1, 2020 22:13

Fix loop error with debug weight UOM.

1c37321

Remove irrelevant translation file.

2766f64

Fkawala requested a review from legalsylvain November 1, 2020 21:22

houssine78 reviewed Nov 9, 2020

View reviewed changes

houssine78 approved these changes Nov 9, 2020

View reviewed changes

Fkawala commented Nov 9, 2020

View reviewed changes

Encode the barcode label using kilogram. Prints the label in the conf…

59b6e7d

…igured UOM.

Fkawala mentioned this pull request Nov 16, 2020

[FIX] pos_tare : raise an error if the gross weight is not correct #566

Merged

legalsylvain reviewed Nov 20, 2020

View reviewed changes

Fix iface_tare_on_scale_screen_method parameters.

2e40ce8

vvrossem suggested changes Mar 8, 2021

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 22, 2021

github-actions bot closed this Sep 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] pos_tare_generate_barcode #527

[12.0][MIG] pos_tare_generate_barcode #527

Fkawala commented Aug 27, 2020

OCA-git-bot commented Aug 27, 2020

legalsylvain left a comment

Fkawala commented Aug 31, 2020 •

edited

Fkawala commented Nov 3, 2020

houssine78 commented Nov 9, 2020

houssine78 Nov 9, 2020

Fkawala Nov 9, 2020

houssine78 Nov 9, 2020

houssine78 Nov 9, 2020

houssine78 Nov 9, 2020

Fkawala Nov 9, 2020

Fkawala Nov 9, 2020

Fkawala Nov 9, 2020 •

edited

Fkawala commented Nov 10, 2020 •

edited

Fkawala commented Nov 11, 2020 •

edited

legalsylvain left a comment

legalsylvain Nov 20, 2020

Fkawala Nov 20, 2020 •

edited

Fkawala Nov 25, 2020

legalsylvain Feb 1, 2021

vvrossem left a comment

vvrossem Mar 8, 2021

vvrossem Mar 8, 2021

vvrossem Mar 8, 2021

github-actions bot commented Aug 22, 2021

[12.0][MIG] pos_tare_generate_barcode #527

[12.0][MIG] pos_tare_generate_barcode #527

Conversation

Fkawala commented Aug 27, 2020

OCA-git-bot commented Aug 27, 2020

legalsylvain left a comment

Choose a reason for hiding this comment

Fkawala commented Aug 31, 2020 • edited

Fkawala commented Nov 3, 2020

houssine78 commented Nov 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fkawala Nov 9, 2020 • edited

Choose a reason for hiding this comment

Fkawala commented Nov 10, 2020 • edited

Fkawala commented Nov 11, 2020 • edited

legalsylvain left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fkawala Nov 20, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vvrossem left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2021

Fkawala commented Aug 31, 2020 •

edited

Fkawala Nov 9, 2020 •

edited

Fkawala commented Nov 10, 2020 •

edited

Fkawala commented Nov 11, 2020 •

edited

Fkawala Nov 20, 2020 •

edited