[ADD][8.0] : Dynamic Price for POS #6

AdilHoumadi · 2014-11-30T22:05:23Z

For more details see README file at :
https://github.com/taktik/pos/blob/8.0-pos_dynamic_price/pos_pricelist/README.rst
Demo of functional Testing : https://www.youtube.com/watch?v=ithM3-TniFE

legalsylvain · 2014-11-30T22:32:33Z

Hi @ah-taktik. Thanks a lot to propose this module. Current POS is a mess for not managing price list.
I'll take a look on your PR at the end of the week.

Best Regards.

This reverts commit 7040fe9.

legalsylvain · 2014-11-30T22:33:11Z

pos_dynamic_price/README.md

+### Missing features :
+
+- As you may know, product template is not fully implemented in the POS, so I decided to drop it from
+this module.


Product template is not managed at all in POS, or there is some pending work I don't know... ?

Yeah absolutely. For v8.0 there no solution for this missing feature !
You can check this discussions :
odoo/odoo#3401 (comment)
odoo/odoo#3500

OK.
I'm actually working on that feature.
UPDATE: available here #7

legalsylvain · 2014-11-30T22:34:01Z

pos_dynamic_price/README.md

@@ -0,0 +1,34 @@
+Dynamic Price for Odoo Point of Sale
+------------------------------------


Maybe the module should be named better 'pos_pricelist'.

Yeah why not :)

coveralls · 2014-11-30T22:41:19Z

Coverage remained the same when pulling 978c741 on taktik:8.0-pos_dynamic_price into a7a8ddb on OCA:8.0.

AdilHoumadi · 2014-11-30T22:41:57Z

At the end of week, I will write some JS tests.

legalsylvain · 2014-12-10T00:12:30Z

Hi @ah-taktik,
Did you began to do write tests ? I'm very interesting to implement JS tests in my PR #7.
2 remarks:

better to change the name for pos_pricelist, for better visilibity (as said before);
~~Can you remove the readme file, and move the text into the description of the module in openerp file, it is more OCA "style" and the text will be visible, on web apps of Odoo, or in Odoo Modules list;~~

Except that point and other technical remarks (below) 👍 (Functional Test)

Thanks a lot for your contribution !

legalsylvain · 2014-12-10T00:13:36Z

pos_dynamic_price/static/src/js/db.js

+            this.pricelist_item_sorted = [];
+            this.product_catrgory_by_id = {};
+            this.product_catrgory_children = {};
+            this.product_catrgory_ancestors = {};


did you mean product_catEgory_by_id (and _children, ancestors...)

pedrobaeza · 2014-12-10T00:15:31Z

README file is OK for version 8.0, because Odoo allows it and you can see also the parsed description on Github, but you have to rename it as README.rst for being parsed correctly in both sides.

legalsylvain · 2014-12-10T00:20:18Z

pos_dynamic_price/static/src/js/models.js

+        /**
+         * override this method to merge lines
+         * TODO : find a better way to do it
+         * @param product


I don't understand why you override this function. Can you explain ? the original function merges lines...

legalsylvain · 2014-12-10T15:51:26Z

@ah-taktik can you send me your email : sylvain.legal @ akretion.com
Thanks.

AdilHoumadi · 2014-12-11T07:44:14Z

@legalsylvain, I sent you a message, check your inbox.

[CHG] : Rename module to pos_pricelist instead of the old one [FIX] : Fix typo mentioned on this comments : - OCA#6 (comment) - OCA#6 (comment) [IMP] : Recover a missed feature while setting a price for an orderline OCA#6 (comment) [IMP] : Switch to while loop while iterating over an array [REM] : Avoid bad practice on Object Class : OCA#6 (comment)

coveralls · 2014-12-20T23:31:20Z

Coverage remained the same when pulling 2092500 on taktik:8.0-pos_dynamic_price into a7a8ddb on OCA:8.0.

coveralls · 2014-12-20T23:46:32Z

Coverage remained the same when pulling 8be730e on taktik:8.0-pos_dynamic_price into a7a8ddb on OCA:8.0.

legalsylvain · 2014-12-20T23:46:54Z

Hi @ah-taktik, Thanks a lot for the refactoring and the various improves !
I'm newb in JS Test, do you have documentation about what you did ? Do you know if Travis execute the tests ? It doesn't seem, or I don't see the result in the log...
Regards.

coveralls · 2014-12-20T23:56:18Z

Coverage remained the same when pulling 4cd140f on taktik:8.0-pos_dynamic_price into a7a8ddb on OCA:8.0.

coveralls · 2014-12-21T00:00:35Z

Coverage remained the same when pulling 4cd140f on taktik:8.0-pos_dynamic_price into a7a8ddb on OCA:8.0.

AdilHoumadi · 2014-12-21T00:09:16Z

Hi @legalsylvain, we can share together our knowledge in JS :

For JS Test in v8.0 : You can check this links,
https://www.youtube.com/watch?v=0GUxV85DDm4#t=24560
https://github.com/odoo/odoodays-2014/blob/master/automated_tests/index.rst

For V7.0 and V8.0 : this one is usable for the two versions :
https://www.odoo.com/documentation/8.0/reference/javascript.html#testing-in-odoo-web-client

I will try to implement the second way when I have sometimes.
I don't think that Travis execute JS Test, maybe need some scripting to do that.

Thanks.

Merge remote-tracking branch 'origin/8.0' into 8.0-pos_dynamic_price * origin/8.0: Remove second env list Separated Lint tests

coveralls · 2014-12-21T00:32:19Z

Coverage remained the same when pulling 90f9243 on taktik:8.0-pos_dynamic_price into 19ee2ae on OCA:8.0.

coveralls · 2014-12-21T01:17:30Z

Coverage remained the same when pulling 3bff8f1 on taktik:8.0-pos_dynamic_price into 19ee2ae on OCA:8.0.

AdilHoumadi · 2014-12-27T11:34:35Z

hello,

@legalsylvain, @pedrobaeza, It's possible to merge this PR ?

Thanks

OSguard · 2014-12-28T12:43:58Z

@ah-taktik please offer some patience, the OCA handles a lot of pull request and the first goal is to keep up quality and avoid fast merges
acording our rules http://odoo-community.org/page/how-to the pull request needs two final reviews. So i think it will happen but all of us have spare time. So thank you for your contribution and a little more patience with us

AdilHoumadi · 2014-12-28T14:02:31Z

@OSguard, Thank you for you feedback. You can take your time.

pedrobaeza · 2014-12-31T17:16:38Z

It works like a charm, but I see only a minor issue: if you select a customer with another pricelist, price tags in the right part (in the upper right part of each product box) still reflects the initial price. Can this be easily changed?

I'm not talking about different prices depending on the quantity, but the base price. Obviously, if you extend also this computation to reflect in that tag all the possible prices (1: x €\n3: y € and so on), it will be marvelous.

AdilHoumadi · 2015-01-01T11:47:05Z

@pedrobaeza, Thank you for you feed back.

For the first point, yeah sure we can do that.
For the second one, I will try to find an ergonomic way to represent data.

[IMP] : refresh product UI to reflects while selecting a customer For more details see the first point of this comment : OCA#6 (comment)

coveralls · 2015-01-01T15:24:37Z

Coverage remained the same when pulling 90e2579 on taktik:8.0-pos_dynamic_price into 19ee2ae on OCA:8.0.

legalsylvain · 2015-02-12T11:52:52Z

Hi Tarik,

Thanks a lot for this excellent module.
It displays now the correct unit price depending of the pricelist.

So for me it's a big 👍

For the rest I would prefer to accept this PR, and let other people to upgrade this module depending of them needs, because this module do the work. (and very correctly)
What do you think about that @pedrobaeza ?

sebastienbeau · 2015-02-12T13:57:20Z

👍 great feature

[ADD][8.0] : POS - manage pricelist in Front End POS

pedrobaeza · 2015-02-12T15:09:47Z

OK, I have added in the README the feature not yet implemented as documentation.

Thanks for the hard work!

AdilHoumadi · 2015-02-12T15:19:16Z

@legalsylvain, @sebastienbeau, @pedrobaeza, Thanks a lot :)

8.0 port account analytic required

Adil Houmadi added 3 commits November 30, 2014 22:55

[ADD] : Dynamic Price for POS

d8b5fce

flake8 is not happy :)

d71e9f2

[FIX] flask8

7040fe9

Revert "[FIX] flask8"

af03649

This reverts commit 7040fe9.

legalsylvain reviewed Nov 30, 2014
View reviewed changes

[FIX] Flake8

978c741

legalsylvain reviewed Nov 30, 2014
View reviewed changes

legalsylvain added the needs review label Nov 30, 2014

legalsylvain added this to the 8.0 milestone Nov 30, 2014

legalsylvain reviewed Dec 10, 2014
View reviewed changes

Adil Houmadi added 2 commits December 17, 2014 23:49

[ADD] Some functional testing

2092500

[FIX] : E302 expected 2 blank lines, found 1

8be730e

[FIX] : fix Readme file

d2c0baa

[FIX] : remove <br/> from readme file

4cd140f

Update from upstream

90f9243

Merge remote-tracking branch 'origin/8.0' into 8.0-pos_dynamic_price * origin/8.0: Remove second env list Separated Lint tests

[FIX] : access to db differently, context is much important !

3bff8f1

[REF] : introduce a new class PricelistEngine to refactor the code

90e2579

[IMP] : refresh product UI to reflects while selecting a customer For more details see the first point of this comment : OCA#6 (comment)

legalsylvain added approved and removed needs review labels Feb 12, 2015

legalsylvain added a commit that referenced this pull request Feb 12, 2015

Merge pull request #6 from taktik/8.0-pos_dynamic_price

7d14e55

[ADD][8.0] : POS - manage pricelist in Front End POS

legalsylvain merged commit 7d14e55 into OCA:8.0 Feb 12, 2015

AdilHoumadi deleted the 8.0-pos_dynamic_price branch February 12, 2015 15:19

adrienpeiffer pushed a commit to acsone/pos that referenced this pull request Nov 30, 2015

Merge pull request OCA#6 from acsone/8.0-port-account-analytic-required

1863b70

8.0 port account analytic required

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][8.0] : Dynamic Price for POS #6

[ADD][8.0] : Dynamic Price for POS #6

AdilHoumadi commented Nov 30, 2014

legalsylvain commented Nov 30, 2014

legalsylvain Nov 30, 2014

AdilHoumadi Nov 30, 2014

legalsylvain Nov 30, 2014

AdilHoumadi Nov 30, 2014

legalsylvain Nov 30, 2014

AdilHoumadi Nov 30, 2014

coveralls commented Nov 30, 2014

AdilHoumadi commented Nov 30, 2014

legalsylvain commented Dec 10, 2014

legalsylvain Dec 10, 2014

pedrobaeza commented Dec 10, 2014

legalsylvain Dec 10, 2014

legalsylvain commented Dec 10, 2014

AdilHoumadi commented Dec 11, 2014

coveralls commented Dec 20, 2014

coveralls commented Dec 20, 2014

legalsylvain commented Dec 20, 2014

coveralls commented Dec 20, 2014

coveralls commented Dec 21, 2014

AdilHoumadi commented Dec 21, 2014

coveralls commented Dec 21, 2014

coveralls commented Dec 21, 2014

AdilHoumadi commented Dec 27, 2014

OSguard commented Dec 28, 2014

AdilHoumadi commented Dec 28, 2014

pedrobaeza commented Dec 31, 2014

AdilHoumadi commented Jan 1, 2015

coveralls commented Jan 1, 2015

legalsylvain commented Feb 12, 2015

sebastienbeau commented Feb 12, 2015

pedrobaeza commented Feb 12, 2015

AdilHoumadi commented Feb 12, 2015

		@@ -0,0 +1,34 @@
		Dynamic Price for Odoo Point of Sale
		------------------------------------

[ADD][8.0] : Dynamic Price for POS #6

[ADD][8.0] : Dynamic Price for POS #6

Conversation

AdilHoumadi commented Nov 30, 2014

legalsylvain commented Nov 30, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 30, 2014

AdilHoumadi commented Nov 30, 2014

legalsylvain commented Dec 10, 2014

Choose a reason for hiding this comment

pedrobaeza commented Dec 10, 2014

Choose a reason for hiding this comment

legalsylvain commented Dec 10, 2014

AdilHoumadi commented Dec 11, 2014

coveralls commented Dec 20, 2014

coveralls commented Dec 20, 2014

legalsylvain commented Dec 20, 2014

coveralls commented Dec 20, 2014

coveralls commented Dec 21, 2014

AdilHoumadi commented Dec 21, 2014

coveralls commented Dec 21, 2014

coveralls commented Dec 21, 2014

AdilHoumadi commented Dec 27, 2014

OSguard commented Dec 28, 2014

AdilHoumadi commented Dec 28, 2014

pedrobaeza commented Dec 31, 2014

AdilHoumadi commented Jan 1, 2015

coveralls commented Jan 1, 2015

legalsylvain commented Feb 12, 2015

sebastienbeau commented Feb 12, 2015

pedrobaeza commented Feb 12, 2015

AdilHoumadi commented Feb 12, 2015