[IMP][13.0] pos_empty_home : Make it configurable and simplify code #642
Conversation
|
ping @hkapatel-initos, would you please help with a review here :) |
|
| class PosConfig(models.Model): | ||
| _inherit = "pos.config" | ||
|
|
||
| iface_empty_home = fields.Boolean( |
There was a problem hiding this comment.
I've reviewed your PR. it is good that the code has been reduced and LGTM.
|
ping @OCA/pos-maintainers , any take on this one? |
|
This PR has the |
|
Thanks! Would you please run the ocabot command again? Unfortunately it's not triggered when written on the review comments |
|
Weird. /ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at fce11ce. Thanks a lot for contributing to OCA. ❤️ |
Hello, two commits here
screens.jsand.cssfiles can be removed.pos.configThe 2nd point is, specially, to be able to run test tours in order modules without this module affecting results, as it completely removes the product list when no category is selected.. which is something most tours would need.
In line with that, "Empty Home" is disabled by default in the demo
pos.config:point_of_sale.pos_config_main, which is the one used by tests normally. It's otherwise enabled by default in all otherpos.config, as this is what you'd expect when installing the module (also to avoid affecting users that already use this module).