[14.0] [mig] pos_fix_search_limit #665
Conversation
|
It would be nice if we could get reviews here. |
|
Hello, @ivantodorovich can you please check it again so we should merge it ASPS. |
Hi, the implementation changed a lot and it was significatly simplified. |
|
Pos_fix_search_limit can't be migrated without lot of code changes. The new layout of functions don't allow enough modularity. So I integrated this feature in the pos_product_template here: akretion@d872722#diff-3e277683278bdd486fadd6746e8669da4432e49edddbd6f24b66343f83b0b51eR91 Do you need pos_fix_search_limit in another context ? |
…th odoo 12 pos. Thanks @hparfr
.product-list may not be present after rendering. This happens when the list is empty, as seen in core code: https://github.com/odoo/odoo/blob/dcb6a3cea27f32d722d1a8dc87c34a846cf5ac23/addons/point_of_sale/static/src/xml/pos.xml#L257 The element is displayed only if product_list.length != 0.
hkapatel-initos
force-pushed
the
14.0-mig-pos_fix_search_limit
branch
from
b72b69c
to
3df3941
Compare
fshah-initos
force-pushed
the
14.0-mig-pos_fix_search_limit
branch
from
3df3941
to
b707acb
Compare
|
Hello, @hparfr and @ivantodorovich it would be nice if you re-check. |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This comment was marked as duplicate.
This comment was marked as duplicate.
github-actions
bot
removed
the
stale
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Closing, as question from @hpar is unanswered since 1 year. Feel free to reopen after having answered. |
No description provided.