[IMP] product_packaging_container_deposit: improve performance #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
force-pushed
the
16-product_packaging_container_deposit-imp-perf
branch
from
16ec8e9
to
be52fb0
Compare
Do not write on `sale.order.order_line` field, this is somehow slowing down the process. Creating/updating `sale.order.line` directly is faster.
sebalix
force-pushed
the
16-product_packaging_container_deposit-imp-perf
branch
from
be52fb0
to
e39e2c7
Compare
simahawk
approved these changes
Jul 8, 2024
cyrilmanuel
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not write on
sale.order.order_linefield, this is somehow slowing down the process (CPU bound). Creating/updatingsale.order.linedirectly is faster.Ref. 1309