[MIG][10.0] product_brand #191

loxamir · 2016-10-20T15:56:04Z

Migrate product_brand to V10

oca-clabot · 2016-10-20T15:56:08Z

Hey @loxamir, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Marcelo Pickler (no github login found)

Appreciation of efforts,
OCA CLAbot

loxamir · 2016-10-20T16:32:05Z

I Confirm I have signed the odoo CLA and send it by email

FIX typo

[FIX] Author field meet limitation for type character varying(128)

Set sale as depence instead of product

loxamir · 2016-10-25T16:58:55Z

everything is green now 😀

leemannd

Thank you for your port. There are only a few things missing (see comments).
Also you can replace 'openerp' in imports on models file with 'odoo'

leemannd · 2016-10-26T06:17:55Z

product_brand/views/product_brand_view.xml

@@ -207,7 +207,7 @@
            name="Product Brands"
            id="menu_product_brand"
            action="action_product_brand"
-            parent="base.menu_product"/>
+            parent="sale.prod_config_main"/>

    </data>
 </openerp>


s/openerp/odoo/

leemannd · 2016-10-26T06:18:10Z

product_brand/views/product_brand_view.xml

@@ -207,7 +207,7 @@
            name="Product Brands"
            id="menu_product_brand"
            action="action_product_brand"
-            parent="base.menu_product"/>
+            parent="sale.prod_config_main"/>

    </data>


can be removed

what can be removed?

<data> tag

leemannd · 2016-10-26T06:22:58Z

product_brand/__manifest__.py

    'category': 'Product',
    'summary': "Product Brand Manager",
    'author': 'NetAndCo, Akretion, Prisnet Telecommunications SA'
              ', MONK Software, Odoo Community Association (OCA)'
              ', SerpentCS Pvt. Ltd.',
    'license': 'AGPL-3',
-    'depends': ['product'],
+    'depends': [
+        'sale',


Are you sure it is correct? Aren't you inheriting views from product.template and product.template class?

sale depends on procurement which depends on product, so it should be ok.

But why do you need so high-level dependency?

He uses it for the menu positioning, he uses sale.prod_config_main as parent menu.
I'm not sure if there is a good lower-level menu to use as reference for positioning, do you have any proposals?

I just depend on sale because of the menu item to keep it in the same place as older versions, if somebody have a better place, I will be glad to position the menu there and change that dependency

OK, I see there's no better option here and I agree that brands are very related with sales.

LeartS

@loxamir Some things could be improved, but nothing blocking, IMO better to have it this way for now that not having it in v10.

The 'sale' dependency is strong, but I don't think there are a lot of people that would be interested in this module without the sale module installed

It would be great to improve the UI of the form view, fixing the smart button alignment:

pedrobaeza · 2016-12-13T19:41:06Z

@loxamir, please attend the comments and I'll merge the PR.

Thanks for your contribution!

lasley · 2016-12-26T20:38:46Z

@loxamir - do you plan on continuing with this PR?

loxamir · 2016-12-27T12:00:55Z

I make my contribution, what should I do now?

pedrobaeza · 2016-12-27T12:02:13Z

You need to correct the comments we have made.

loxamir · 2016-12-27T14:24:30Z

I have made all the changes requested in comments except UI improvement which I let for anyone else do that

lasley

Thanks @loxamir - would you mind adding the view improvement note to the roadmap so we don't lose it going forward?

pedrobaeza · 2016-12-27T17:47:52Z

And please squash your commits together

loxamir · 2016-12-27T17:50:54Z

@lasley how can I do that?

lasley · 2016-12-27T17:53:09Z

@loxamir - There is a RoadMap section in the Readme, just add a bullet so we don't lose the bug note:

* Fix smart button alignment in brand form view

The squashing Pedro refers to is like this. We can do it for you too, but it's good for you to know how IMO. Squashing makes for way better commit histories, and works great in personal projects too.

lasley · 2016-12-27T17:54:55Z

product_brand/README.rst

@@ -35,7 +35,7 @@ For further information, please visit:
 Known issues / Roadmap
 ======================

-* Add a field with brands assiciated to a Customer or Supplier on 
+* Add a field with brands associated to a Customer or Supplier on
  the Customers/Suppliers Form View.


Add the bullet here 😄

done, thanks @lasley

FIX typo Update __manifest__.py [FIX] Author field meet limitation for type character varying(128) [FIX] Wrong depence Set sale as depence instead of product s/openerp/odoo Removed <data> tag Add view fix to roadmap

…sasa/product-attribute into migrate_product_brand_to_v10

loxamir · 2016-12-28T13:21:48Z

I have made the squash, what more should I do?

lasley · 2016-12-28T17:11:04Z

HI @loxamir - doesn't look like the squash went through, that should have reduced the commit count to 1 - we're still at 10. Not a big deal though, we can just squash on merge.

Thanks for the submission, I look forward to seeing you around OCA! I don't have write access in this repo, but someone that does will squash & merge this soon.

pedrobaeza · 2016-12-28T17:39:03Z

OK, squashing on merge then

loxamir · 2016-12-28T17:40:27Z

thanks @lasley @pedrobaeza and all other that help me make this contribution 👍
I will be better on the next :)

Migration to 10.0

…when this method it's call from website (OCA#191)

Migration to 10.0

[IMP] Migrate to v10

a425674

legalsylvain and others added 2 commits October 20, 2016 19:35

FIX typo

4415ff6

Merge pull request #1 from rossasa/legalsylvain-patch-1

22f6dbd

FIX typo

gurneyalex changed the title ~~[IMP] Migrate to v10~~ [MIG][10.0] product_brand Oct 24, 2016

pedrobaeza mentioned this pull request Oct 24, 2016

Migration to version 10.0 #184

Closed

35 tasks

loxamir mentioned this pull request Oct 25, 2016

[IMP] website_sale_product_brand: Migrate to v10 OCA/e-commerce#136

Closed

loxamir added 2 commits October 25, 2016 13:01

Update __manifest__.py

063b1b8

[FIX] Author field meet limitation for type character varying(128)

[FIX] Wrong depence

58e1932

Set sale as depence instead of product

leemannd suggested changes Oct 26, 2016

View reviewed changes

leemannd reviewed Oct 26, 2016

View reviewed changes

LeartS approved these changes Dec 13, 2016

View reviewed changes

loxamir added 2 commits December 27, 2016 09:14

s/openerp/odoo

a815fa5

Removed <data> tag

ccc96b7

lasley approved these changes Dec 27, 2016

View reviewed changes

lasley reviewed Dec 27, 2016

View reviewed changes

loxamir and others added 3 commits December 27, 2016 14:55

Add view fix to roadmap

3792046

[IMP] Migrate to v10

4e7c01e

FIX typo Update __manifest__.py [FIX] Author field meet limitation for type character varying(128) [FIX] Wrong depence Set sale as depence instead of product s/openerp/odoo Removed <data> tag Add view fix to roadmap

Merge branch 'migrate_product_brand_to_v10' of https://github.com/ros…

56bda29

…sasa/product-attribute into migrate_product_brand_to_v10

pedrobaeza merged commit 7deb190 into OCA:10.0 Dec 28, 2016

jeanpaulrobineau pushed a commit to apertoso/product-attribute that referenced this pull request Oct 31, 2017

[MIG][10.0] product_brand (OCA#191)

092208f

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 15, 2018

[MIG][10.0] product_brand (OCA#191)

cb7c19b

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 19, 2018

[MIG][10.0] product_brand (OCA#191)

92094bc

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 19, 2018

[MIG][10.0] product_brand (OCA#191)

e69eded

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 19, 2018

[MIG][10.0] product_brand (OCA#191)

5dae6ee

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 19, 2018

[MIG][10.0] product_brand (OCA#191)

ee58d4e

Migration to 10.0

Daniel-CA pushed a commit to Daniel-CA/product-attribute that referenced this pull request Mar 19, 2018

[MIG][10.0] product_brand (OCA#191)

d92f1db

Migration to 10.0

pedrobaeza pushed a commit to Daniel-CA/product-attribute that referenced this pull request Apr 4, 2018

[MIG][10.0] product_brand (OCA#191)

fe5fab6

Migration to 10.0

pedrobaeza pushed a commit to Daniel-CA/product-attribute that referenced this pull request Apr 4, 2018

[MIG][10.0] product_brand (OCA#191)

6fc19c1

Migration to 10.0

ghost pushed a commit to camptocamp/product-attribute that referenced this pull request Jul 23, 2018

[MIG][10.0] product_brand (OCA#191)

b99a96f

Migration to 10.0

ghost pushed a commit to camptocamp/product-attribute that referenced this pull request Jul 23, 2018

[MIG][10.0] product_brand (OCA#191)

18f5f64

Migration to 10.0

ghost pushed a commit to camptocamp/product-attribute that referenced this pull request Jul 23, 2018

[MIG][10.0] product_brand (OCA#191)

ddc5721

Migration to 10.0

ThomasBinsfeld pushed a commit to acsone/product-attribute that referenced this pull request Oct 2, 2018

[MIG][10.0] product_brand (OCA#191)

45f7cb8

Migration to 10.0

ThomasBinsfeld pushed a commit to acsone/product-attribute that referenced this pull request Oct 25, 2018

[MIG][10.0] product_brand (OCA#191)

a0a8f1b

Migration to 10.0

ernestotejeda pushed a commit to Tecnativa/product-attribute that referenced this pull request Aug 22, 2019

[FIX] we add prefetch_fields becase if not the stock it's no correct …

d45a732

…when this method it's call from website (OCA#191)

smurf-U pushed a commit to smurf-U/product-attribute that referenced this pull request Oct 15, 2019

[MIG][10.0] product_brand (OCA#191)

1a5ef43

Migration to 10.0

filoquin pushed a commit to filoquin/product-attribute that referenced this pull request Apr 23, 2020

[MIG][10.0] product_brand (OCA#191)

1e3b444

Migration to 10.0

HviorForgeFlow pushed a commit to ForgeFlow/product-attribute that referenced this pull request Jun 22, 2020

[MIG][10.0] product_brand (OCA#191)

8726b67

Migration to 10.0

BT-dherreros pushed a commit to BT-dherreros/product-attribute that referenced this pull request Jan 25, 2021

[MIG][10.0] product_brand (OCA#191)

c0f91f8

Migration to 10.0

BT-dherreros pushed a commit to BT-dherreros/product-attribute that referenced this pull request Jan 25, 2021

[MIG][10.0] product_brand (OCA#191)

9ab494e

Migration to 10.0

xavier-bouquiaux pushed a commit to acsone/product-attribute that referenced this pull request Apr 13, 2021

[MIG][10.0] product_brand (OCA#191)

4ea9388

Migration to 10.0

xavier-bouquiaux pushed a commit to acsone/product-attribute that referenced this pull request Apr 13, 2021

[MIG][10.0] product_brand (OCA#191)

0c9e619

Migration to 10.0

ygcarvalh pushed a commit to kmee/product-attribute that referenced this pull request May 31, 2021

[MIG][10.0] product_brand (OCA#191)

f24d073

Migration to 10.0

stefsava pushed a commit to stefsava/product-attribute that referenced this pull request Jul 25, 2021

[MIG][10.0] product_brand (OCA#191)

3ccc78a

Migration to 10.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][10.0] product_brand #191

[MIG][10.0] product_brand #191

loxamir commented Oct 20, 2016

oca-clabot commented Oct 20, 2016

loxamir commented Oct 20, 2016

loxamir commented Oct 25, 2016

leemannd left a comment

leemannd Oct 26, 2016

leemannd Oct 26, 2016

loxamir Dec 27, 2016

pedrobaeza Dec 27, 2016

leemannd Oct 26, 2016

LeartS Dec 13, 2016

pedrobaeza Dec 13, 2016

LeartS Dec 13, 2016 •

edited

loxamir Dec 13, 2016

pedrobaeza Dec 13, 2016

LeartS left a comment •

edited

pedrobaeza commented Dec 13, 2016

lasley commented Dec 26, 2016

loxamir commented Dec 27, 2016

pedrobaeza commented Dec 27, 2016

loxamir commented Dec 27, 2016

lasley left a comment •

edited

pedrobaeza commented Dec 27, 2016

loxamir commented Dec 27, 2016

lasley commented Dec 27, 2016 •

edited

lasley Dec 27, 2016

loxamir Dec 27, 2016

loxamir commented Dec 28, 2016

lasley commented Dec 28, 2016 •

edited

pedrobaeza commented Dec 28, 2016

loxamir commented Dec 28, 2016 •

edited

[MIG][10.0] product_brand #191

[MIG][10.0] product_brand #191

Conversation

loxamir commented Oct 20, 2016

oca-clabot commented Oct 20, 2016

loxamir commented Oct 20, 2016

loxamir commented Oct 25, 2016

leemannd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeartS Dec 13, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeartS left a comment • edited

Choose a reason for hiding this comment

pedrobaeza commented Dec 13, 2016

lasley commented Dec 26, 2016

loxamir commented Dec 27, 2016

pedrobaeza commented Dec 27, 2016

loxamir commented Dec 27, 2016

lasley left a comment • edited

Choose a reason for hiding this comment

pedrobaeza commented Dec 27, 2016

loxamir commented Dec 27, 2016

lasley commented Dec 27, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loxamir commented Dec 28, 2016

lasley commented Dec 28, 2016 • edited

pedrobaeza commented Dec 28, 2016

loxamir commented Dec 28, 2016 • edited

LeartS Dec 13, 2016 •

edited

LeartS left a comment •

edited

lasley left a comment •

edited

lasley commented Dec 27, 2016 •

edited

lasley commented Dec 28, 2016 •

edited

loxamir commented Dec 28, 2016 •

edited