Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 9.0 product_code_builder #204

Closed
wants to merge 28 commits into from
Closed

[MIG] 9.0 product_code_builder #204

wants to merge 28 commits into from

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Nov 13, 2016

migration from 8.0
depends of #203

mileo and others added 27 commits November 13, 2016 18:44
@mileo @lmignon
Add new module: product_attribute_priority
ad458af
@bealdav @lmignon
add attribute_sequence field
68520a7
@gurneyalex @lmignon
fix the help of the new fields
43465b6 
the help must be a string, not a tuple.
@lmignon
[MIG] product_attribute_priority from 8.0
6e00bf8
@bguillot @lmignon
Add Product Attribute Code
641f1cf 
[ADD] Add Porduct Attribute Global Item Code

[FIX] Problems in openerp file

[ADD] README

[ADD] README

[FIX] modify openerp and product

[FIX] Sql Constraints

[FIX] Sql Constraints v2

[FIX] Product Attribute Global Item Code

[FIX] problems with openerp and init files

[FIX] problems with product file

[DEL] delete Product Variant inactive

[FIX] README image

[FIX] readme Image

[FIX] readme Image V2

[FIX] readme Image V2

[FIX] readme Image V2

[FIX] regenerate and update fr.po

[FIX] i18n and add comments

[ADD] Odoo Community Association (OCA) as author in the list and cut image

[FIX] help

[ADD] help in product file

[ADD] help in product file

[MOD] modify init file

[FIX] delete Blank line

[FIX] error code

[MOD] modify Readme file

[fix] product file

[FIX]  blank lines

[MOD] product file

[add] handle in view file

[FIX] product_attribute_global_item_code

[FIX] problem code and rename use_manual_internal_ref field

[FIX] remane use_manual_ref to use_manual_internal_ref

[FIX] merge global_code with code models

[DEL] delete product_attribute_code

[FIX] rename product builder code

[IMP] improve product file

[IMP] improve product code builder

[ADD] auto_install and installable in openerp file

[IMP] blank line at end of file

[FIX] Readme and product files
@ahilali @lmignon
improve product code builder
fcbff60
@sebastienbeau @lmignon
as the field have been rename (to the opposite) the code should be up…
27bb259 
…dated, and also the field name
@sebastienbeau @lmignon
simplify build code and FIX the recompute when changing the base_code…
bf4925a 
…, wrong value in the depends
@sebastienbeau @lmignon
rename product_code into product_attribute
3d5633a
@bealdav @lmignon
remove readonly field
d981224
@bealdav @lmignon
_get_default_code
797073f
@lmignon
product Code Builder
fd5c992
@lmignon
Product Code
ddd34df
@bealdav @lmignon
build product code according to the order of the attribute code
da3b6af
@bealdav @lmignon
add test unit, simplify code, documentation
be4c6d7
@lmignon
Improve module product_code_builder
263434a 
Fix tests
Add documentation
Translate and Pep8 in test_code.py
Add incompatibilty with product_sequence module
Change behavior of auto

Auto = On -> generate default_code
Auto = Off -> use only user provided default_code

Previously prefix was used with auto == off
@hparfr @lmignon
Update documentation
141bf92
@sebastienbeau @lmignon
fix installation, set False for existing record
855fbb6
@sebastienbeau @lmignon
when installing the module the existing code must be kept
a1ce642
@sebastienbeau @lmignon
fix test
4abfdbc
@sebastienbeau @lmignon
fix dependency, only need to depend of product
2cfb559
@sebastienbeau @lmignon
add uniq constraint on prefix code
12e7327
@sebastienbeau @lmignon
fix edition of default code for none varianted product and also fix c…
17b34f1 
…ompatibility with other module
@sebastienbeau @lmignon
initialize the prefix code by the default code of the product
7347d3c
@sebastienbeau @lmignon
improve UI and help
ea7514f
@sebastienbeau @lmignon
simplify code to compute the default code, use order on attribute val…
a2fba33 
…ue for computing the default code
@bealdav @lmignon
add instruction to migrate product_code_builder
fbad67c
@lmignon lmignon mentioned this pull request Nov 13, 2016
Closed
@lmignon lmignon force-pushed the 9.0-mig-product_code_builder-lmi branch from 9f99bd1 to 6113e0c Compare November 13, 2016 21:03
bealdav
bealdav reviewed Jan 27, 2017
View reviewed changes
product_code_builder/__openerp__.py
'category': 'Product',
'version': '9.0.1.0.0',
'depends': [
'product',
Copy link
Member

@bealdav bealdav Jan 27, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one 1 dependency sufficient ? the last, I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news @lmignon ? Do you want a PR, there ?

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bealdav Sorry for the late reply... Both are required since I extends the views defined in product and therefore I have a direct dependency on product. In case of direct dependency it's always better to avoid to rely on the fact that this dependency is transitively acquired by an other one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bealdav
Copy link
Member

bealdav commented Jan 27, 2017

Thanks for your work @lmignon.
You have make product_attribute_priority and product_code_builder compatible.
Ca c'est fait, merci
@EBII please review and test in v9 before to go to v10, thanks

@EBII
Copy link
Contributor

EBII commented Jan 27, 2017

seems ok and doing the job

@sebastienbeau sebastienbeau mentioned this pull request Mar 30, 2017
Closed
gdgellatly
gdgellatly reviewed Apr 11, 2017
View reviewed changes
product_code_builder/models/product_attribute_value.py

class ProductAttributeValue(models.Model):
_inherit = "product.attribute.value"
_code = "code"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this line do? I'm trying to port to 10 but can find no usage of it anywhere in odoo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake 726c16e
it must be _order = 'code' . Sorry for that

@bealdav
Copy link
Member

bealdav commented Apr 12, 2017

@gdgellatly Note that product_attribute_priority (dependent module) is ported to v9

@gdgellatly
Copy link
Contributor

@bealdav OK I've given it my best shot. Note in v10 most of the features in product_attribute_priority already exist in product module - see #244

@gdgellatly gdgellatly mentioned this pull request Apr 20, 2017
Closed
@pedrobaeza
Copy link
Member

I think this is not needed anymore with the revamp product_variant_default_code in OCA/product-variant. Isn't it?

@gdgellatly
Copy link
Contributor

gdgellatly commented Feb 23, 2018 via email

@pedrobaeza
Copy link
Member

Uhm, right. OK, but I'm seeing this in a place that maybe is not the best, and it requires 3 modules to work. I think it's better to backport the other one.

@gdgellatly
Copy link
Contributor

gdgellatly commented Feb 23, 2018 via email

@rousseldenis
Copy link
Sponsor Contributor

Closing this as very old. Please feel free to reopen it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bealdav bealdav bealdav left review comments

@gdgellatly gdgellatly gdgellatly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet