Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] product_sequence: Migration to 12.0 #507

Merged
merged 24 commits into from Oct 1, 2019
Merged

[12.0][MIG] product_sequence: Migration to 12.0 #507

merged 24 commits into from Oct 1, 2019

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Sep 27, 2019

Superseded #416

@Tecnativa TT19422

@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Sep 27, 2019
Jordi Esteve and others added 23 commits September 27, 2019 19:52
@Tardo
[ADD] product_sequence: Allows to associate a sequence to the product…
99355af 
… reference. The reference (default code) is unique (SQL constraint) and required.
@sebastienbeau @Tardo
[MERGE] merge translation commited by launchpad on extra-addons6.0
ac5af35
@bguillot @Tardo
[FIX] fix write all product with default_code together and then write…
a757659 
… each product without default_code
@eLBati @Tardo
[FIX] resetting sequence code when updating module
5d724b7
@Tardo
[REM] use Model instead of osv.osv
5004cec 
some minor reformatting in the process
@sebastienbeau @Tardo
[FIX] product_sequence : write should support list or integer
bd38f5b
@guewen @Tardo
[MIGR] migration of product_sequence to openerp 7.0 (required for pro…
ef059e9 
…duct_images)
@Tardo
FIX description of module product_custom_attributes.
78a31da 
Version numbers should only have 2 digits.
@Tardo
Launchpad automatic translations update.
6d1071e
@Tardo
Set all addons to uninstallable and move them into __unported__ folder
1238b03
@angelmoya @Tardo
MIG product_sequence
339f96e
@Tardo
Added german translation
943926a
@yvaucher @Tardo
Add bug tracker link on README.rst
9019ede
@gdgellatly @Tardo
product_sequence
4cfdd04 
Add pre_init_hook to manually set nulls and '/' default codes
 to a unique code to greenify branch
add pragma to pre_init method as it must have completed successfully
if module installs
@yvaucher @Tardo
Add missing default oca icons
8b3dfc8
@SodexisTeam @Tardo
product_sequence (OCA#156)
a8f33ab
@atchuthan @Tardo
[MIG][10.0] migrate product_sequence
cf0e426
@oca-transbot @Tardo
OCA Transbot updated translations from Transifex
5b1988f
@LoisRForgeFlow @Tardo
[11.0][MIG/IMP] product_sequence:
76390ee 
* Migration to v11
* Support sequence by Product Category
@JordiBForgeFlow @Tardo
fixes and adds tests
5e223f9
@sbidoul @Tardo
remove obsolete .pot files [ci skip]
1b4cb02
@oca-travis @Tardo
[UPD] Update product_sequence.pot
3f525b6
@sudhir-erpharbor @Tardo
[MIG] Migrated product_sequence to v12
668d507
@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

rafaelbn
rafaelbn approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionaly 👍

@rafaelbn
Copy link
Member

Please @Tardo answer review from @Trivedi-Vacha-SerpentCS , thanks!

nikul-serpentcs
nikul-serpentcs reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change

product_sequence/data/product_sequence.xml Outdated Show resolved Hide resolved
product_sequence/views/product_category.xml Outdated Show resolved Hide resolved
@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@oca-clabot
Copy link

Hey @Tardo, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Tardo
Copy link
Member Author

Tardo commented Sep 30, 2019

Thanks @Trivedi-Vacha-SerpentCS and @nikul-serpentcs changes done.

nikul-serpentcs
nikul-serpentcs approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM 👍

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-507-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2019
@OCA-git-bot
Merge PR #507 into 12.0
9eb6c6a 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 69a12c3 into OCA:12.0 Oct 1, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d27692. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Oct 8, 2019
Closed
@yajo yajo deleted the 12.0-mig-product_sequence branch October 30, 2019 11:23
@emagdalenaC2i emagdalenaC2i mentioned this pull request Feb 19, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet