[12.0][MIG] product_profile #546

kevinkhao · 2020-01-06T14:33:26Z

No description provided.

legalsylvain · 2020-01-06T18:17:55Z

CC : original authors : @EBII, @bealdav, @sebastienbeau

nikul-serpentcs

nitpicking

nikul-serpentcs · 2020-01-07T04:47:59Z

product_profile/__manifest__.py

+    "summary": "Allow to configure a product in 1 click",
+    "category": "product",
+    "depends": ["sale"],
+    "website": "http://www.akretion.com/",


https://github.com/OCA/product-attribute

Thanks Nikul !

nikul-serpentcs · 2020-01-07T04:50:34Z

product_profile/views/product_view.xml

+        <field name="inherit_id" ref="product.product_template_form_view"/>
+        <field name="arch" type="xml">
+            <xpath expr="//h1" position="after">
+                <group>


Suggested change

<group>

<group name='profile'>

EBII

anything else seems Ok

EBII · 2020-01-08T10:49:35Z

product_profile/__manifest__.py

+    "author": "Akretion, Odoo Community Association (OCA)",
+    "summary": "Allow to configure a product in 1 click",
+    "category": "product",
+    "depends": ["sale"],


in 12.0 i think you need to depends sale_managment instead sale to get product menu in sale app and not just invoice app..

EBII · 2020-01-08T15:15:07Z

product_profile/models/product.py

+
+
+class ProductProfile(models.Model):
+    _name = "product.profile"


Please add _descritpion =" xx" to remove warnings

EBII · 2020-01-08T15:15:37Z

product_profile/models/product.py

+
+
+class ProductMixinProfile(models.AbstractModel):
+    _name = "product.mixin.profile"


please add _description to remove warnings

EBII · 2020-01-08T15:35:25Z

product_profile/models/product.py

+                {"profile_id": self.profile_id.id}
+            )
+            for field, value in values.items():
+                try:


i think is necessary to avoid id that generate error message on change profile on product

Suggested change

try:

if field != 'id':

try:

self[field] = value

Hi EBII, thank you for your feedback!

I think that field should be excluded already because of exclusion of fields , did you manage to trigger an error message ?

Yes @kevinkhao it generate the error message in the except

get_profile_fields_to_exclude() is only call on write method.. You can call it On the on change instead of just filter the id.
but not sure it is necessary or it's work

Suggested change

try:

excludable_fields = get_profile_fields_to_exclude()

for field, value in values.items():

if field not in excludable_fields:

try:

EBII

thanks for your work.

EBII · 2020-01-09T17:22:10Z

@bealdav

bealdav · 2020-01-10T11:34:25Z

product_profile/models/product.py

+    )
+    explanation = fields.Text(
+        required=True,
+        oldname="description",


Please remove oldname

bealdav · 2020-01-10T11:37:43Z

product_profile/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+"access_product_brand_product_manager","product.profile","model_product_profile","base.group_user",1,0,0,0


product_brand_product_manager ?

missing a security rule to update/create profiles

bealdav · 2020-01-10T11:41:59Z

product_profile/models/product.py

+    def create(self, vals):
+        if vals.get("profile_id"):
+            vals.update(self._get_vals_from_profile(vals))
+        return super(ProductMixinProfile, self).create(vals)


in python 3 you may have super().create() each time super has self arg

The same things in other parts of the script

sebastienbeau · 2020-02-10T11:51:18Z

In order to improve the readability and make easier to track teh change it will be great if you can do the migration in two commit.
One for the structural change (splitting the file product.py in two file and running black)
One for the real logic change (improving readme, migration of the code....)

Thanks for your work
Note travis is read

kevinkhao · 2020-02-10T13:05:15Z

In order to improve the readability and make easier to track teh change it will be great if you can do the migration in two commit.
One for the structural change (splitting the file product.py in two file and running black)
One for the real logic change (improving readme, migration of the code....)

Thanks for your work
Note travis is read

Noted, will do, thanks

bealdav

Except typo ok for me
Review and test UI

product_profile/models/product.py

product_profile/models/product_profile.py

Currently translated at 100.0% (31 of 31 strings) Translation: product-attribute-10.0/product-attribute-10.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-10-0/product-attribute-10-0-product_profile/es/

rousseldenis · 2020-06-22T15:01:31Z

@EBII @nikul-serpentcs Could you approve ?

nikul-serpentcs

@rousseldenis Now Code LGTM 👍

OCA-git-bot · 2020-07-17T11:16:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2020-07-17T11:16:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bealdav · 2020-07-17T11:45:27Z

/ocabot merge major

OCA-git-bot · 2020-07-17T11:45:44Z

Sorry @bealdav you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

bealdav · 2020-07-17T11:46:35Z

Ok not yet maintainer

rousseldenis · 2020-07-17T12:48:17Z

/ocabot merge major

OCA-git-bot · 2020-07-17T12:48:36Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-546-by-rousseldenis-bump-major, awaiting test results.

OCA-git-bot · 2020-07-17T13:18:36Z

Congratulations, your PR was merged at cb7f48b. Thanks a lot for contributing to OCA. ❤️

This was referenced Jan 6, 2020

[12.0][MIG] product_profile_example #547

Closed

Migration to version 12.0 #389

Closed

nikul-serpentcs reviewed Jan 7, 2020

View reviewed changes

kevinkhao force-pushed the 12.0-mig-product_profile branch from c31bb57 to 701c805 Compare January 8, 2020 14:46

EBII reviewed Jan 8, 2020

View reviewed changes

kevinkhao force-pushed the 12.0-mig-product_profile branch from 701c805 to 21ef11a Compare January 8, 2020 16:39

EBII reviewed Jan 9, 2020

View reviewed changes

kevinkhao force-pushed the 12.0-mig-product_profile branch from 21ef11a to 7f63001 Compare January 9, 2020 10:46

bealdav suggested changes Jan 10, 2020

View reviewed changes

kevinkhao force-pushed the 12.0-mig-product_profile branch 4 times, most recently from b08c1bc to fe4b989 Compare January 14, 2020 16:41

kevinkhao force-pushed the 12.0-mig-product_profile branch 2 times, most recently from 7194494 to a3782a3 Compare February 3, 2020 11:37

kevinkhao force-pushed the 12.0-mig-product_profile branch 4 times, most recently from 9d6ae37 to 2e67995 Compare February 13, 2020 04:20

kevinkhao force-pushed the 12.0-mig-product_profile branch 4 times, most recently from 20f8384 to 60ca1d3 Compare February 23, 2020 21:46

bealdav approved these changes Mar 3, 2020

View reviewed changes

kevinkhao force-pushed the 12.0-mig-product_profile branch from 9819311 to 9e25860 Compare March 6, 2020 14:44

product_profile module

a4bf899

EBII and others added 10 commits March 6, 2020 16:00

code review

b2ff73a

[FIX] pylint

45e716e

OCA Transbot updated translations from Transifex

e9b5921

OCA Transbot updated translations from Transifex

db2053e

FIX set explicitely profile_id string field

a846970

[UPD] Update product_profile.pot

cf0da5f

[FIX] do not customize product easy form view

c4be9d6

[IMP] product_profile: black, file structure change

bede9ec

[MIG][12.0] product_profile: Migration to 12.0

3156bd7

kevinkhao force-pushed the 12.0-mig-product_profile branch from 9e25860 to 3156bd7 Compare March 6, 2020 15:02

fixup! remove unused demo file

f9144b9

rousseldenis added the migration label Jun 22, 2020

rousseldenis added this to the 12.0 milestone Jun 22, 2020

nikul-serpentcs approved these changes Jul 17, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 17, 2020

OCA-git-bot added the bot is merging ⏳ label Jul 17, 2020

OCA-git-bot merged commit 39ab783 into OCA:12.0 Jul 17, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] product_profile #546

[12.0][MIG] product_profile #546

kevinkhao commented Jan 6, 2020

legalsylvain commented Jan 6, 2020

nikul-serpentcs left a comment

nikul-serpentcs Jan 7, 2020

kevinkhao Jan 8, 2020

nikul-serpentcs Jan 7, 2020

EBII left a comment

EBII Jan 8, 2020

EBII Jan 8, 2020

EBII Jan 8, 2020

EBII Jan 8, 2020

kevinkhao Jan 8, 2020 •

edited

Loading

EBII Jan 9, 2020

EBII left a comment

EBII commented Jan 9, 2020

bealdav Jan 10, 2020

bealdav Jan 10, 2020

bealdav Jan 10, 2020

sebastienbeau commented Feb 10, 2020

kevinkhao commented Feb 10, 2020

bealdav left a comment

rousseldenis commented Jun 22, 2020

nikul-serpentcs left a comment

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

bealdav commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

bealdav commented Jul 17, 2020

rousseldenis commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020



		class ProductProfile(models.Model):
		_name = "product.profile"



		class ProductMixinProfile(models.AbstractModel):
		_name = "product.mixin.profile"

-                try:
+                if field != 'id':
+                        try:
+                            self[field] = value

-                try:
+excludable_fields = get_profile_fields_to_exclude()
+for field, value in values.items():
+    if field not in excludable_fields:
+                try:

		@@ -0,0 +1,2 @@
		"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
		"access_product_brand_product_manager","product.profile","model_product_profile","base.group_user",1,0,0,0

[12.0][MIG] product_profile #546

[12.0][MIG] product_profile #546

Conversation

kevinkhao commented Jan 6, 2020

legalsylvain commented Jan 6, 2020

nikul-serpentcs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EBII left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinkhao Jan 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EBII left a comment

Choose a reason for hiding this comment

EBII commented Jan 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebastienbeau commented Feb 10, 2020

kevinkhao commented Feb 10, 2020

bealdav left a comment

Choose a reason for hiding this comment

rousseldenis commented Jun 22, 2020

nikul-serpentcs left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

bealdav commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

bealdav commented Jul 17, 2020

rousseldenis commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

kevinkhao Jan 8, 2020 •

edited

Loading