customer context in product view port to v8 #76
Conversation
Remove non working code Change module name to better reflect new scope Update button to smart button Reorganize to new coding guidelines Add README.RST bump minor version number
|
I think you will find I have signed the CLA |
Fix failing lint
|
CLA ok 😸 |
| To install this module, you need to: | ||
|
|
||
| * do nothing special | ||
|
|
There was a problem hiding this comment.
I think this paragraph should be removed
There was a problem hiding this comment.
@gurneyalex I wrote it as a joke initially, however the more I think about it I think it should stay in or we should have some standard wording of the same effect and add it to quality tools. Telling a user what they don't need to do is equally valuable as telling them what they do need to do, and if we put it everywhere and make consistent it will prompt module developers when it changes.
Maybe a simple line like, This Module has no specific installation requirements, and for the one below, This module requires no post installation configuration
|
runbot status related to #77 2 non blocking remarks. 👍 |
…0-port-customer-context-in-product-view
|
👍 tested on runbot |
|
@pedrobaeza can we make a call on whether we merge this or not. I'm long since over v8 so happy to close as well and I've done the v10 port work in #246 . |
|
OK, let's merge it to have it for those using v8. |
Remove non working code
Change module name to better reflect new scope
Update button to smart button
Reorganize to new coding guidelines
Add README.RST
bump minor version number