[MIG] product_packaging_type: Migration to 14.0 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Context**
* Manage UNECE codes on packaging
* Be able to express a packaging qty in smallest packaging qty
* Simplify packaging name management to ease translation and avoid people to write a name every time they add a packaging on a product
**Usage**
When I open a product form, in the inventory tab I want to see the product packaging and its related code I can quickly see the Qty per packaging to know how much of a given packaging is contain in another
**TODO**
* Update (Improve) the module "product_packaging_type" from product-attribute (I think ) to:
* in the product "Inventory" tab form (Packaging list view)
* Hide the name of the packaging
* Move the "Packaging type" in the first position
* When opening the packaging form view from "Inventory" tab of the product
* Replace the name by packaging type at the top
* Hide name field, but populate it with on_change of packaging with the packaging type name
* Name of the packaging type:
* name_get should be: "NAME + ' ' + (CODE)" -> e.g. Retail box (HV)
* name_get of the product packaging should be overridden:
```python
if product_id is set:
return packaging_type name (e.g. Transport box)
else:
return the recorded packaging name on the packaging (e.g. DHL box)
```
The constraint was added by module OCA/stock-logistics-warehouse::stock_cubiscan, which makes no sense, see: https://github.com/OCA/stock-logistics-warehouse/blob/95cc85c470dcdf6f41cec828e39beac4a9786c80/stock_cubiscan/models/stock.py#L15-L26 We should have only one type of packaging per product, but there is a twist for the default packaging. As the packaging type is required on a package, to be a good player with other modules and existing data, a default packaging type is created, and is used as a default value. An existing database with 4 packaging per product will have the default on all the packagings. So the unique constraint ignores the default type, allowing users to transition to the proper types.
…False In product packaging form view the "Has GTIN" is invisible
The SQL constraint I added previously [0] prevent some demo data to be installed (e.g. in module OCA/wms::stock_storage_type). The issue is that the packaging type is required, is part of the unique constraint, and has a default packaging type. When the module is installed and we have existing data or demo data, the default type will be set on all the packagings, meaning we have to ignore the unique constraint on the default type. This was already handled using an "EXCLUDE" constraint, but it does not solve the issue with demo data, the related field "packaging_type_is_default", used as exclusion for the unique constraint, is first inserted with a NULL value before being set to True. [0] OCA#654
Currently translated at 100.0% (25 of 25 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_packaging_type Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_packaging_type/es/
44 tasks
phuctranfxvn
force-pushed
the
14.0-mig-product_packaging_type
branch
from
93a94d4
to
2413c99
Compare
hparfr
approved these changes
Jan 13, 2021
4 tasks
rvalyi
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
I approve the migration through basically it only consists in changing the version number to 14, so I'm not too sure if it is fair to make you a listed module contributor (this would not scale). I guess this is to be decided with CampToCamp authors. cc @damdam-s @jgrandguillaume
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 45e19d9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.