New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 new product attribute group #79
Conversation
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | ||
:alt: License: AGPL-3 | ||
|
||
Module name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put the actual module name
f359b7b
to
396af8f
Compare
710139b
to
396af8f
Compare
Add new module product_attribute_group to support the grouping of attributes for reuse within product templates. Fix wrong copyright file Fix flake8 failures Fix error in demo data Fix Readme as per Pedro Little bit of cleanup and additional demo data Add tests
396af8f
to
69e536b
Compare
@gurneyalex can you help me. I don't know what to do here. Travis keeps failing, but here are my test results with product_sequence installed on this branch on a test database. I have no idea why it doesn't call the product_sequence overrides on travis to create the codes. (You can see by the long runtime I spent a lot of time in debug ensuring that they are called) 2015-06-25 04:35:57,779 20656 INFO seq_test5 openerp.modules.module: openerp.addons.product_attribute_group.tests.test_attribute_group running tests. |
@gurneyalex @bwrsandman Hi, I've retested this using the travis commands exactly on a local machine. I think it is a real problem and we might need to change the test script. Findings The upshot of this is that I think the test runner should loop over the directories and run --update (1 module) each time. It seems that update does not load the modules to be updated before testing. Even then it is still not ideal, as in theory an installed module could incorrectly cause a test to pass or fail. |
@gdgellatly after a (long) while, rebuilding in travis is almost green : only lint errors remain. Are you still interested in this PR? |
@gurneyalex Wow, sorry I missed this, actually I am still really interested but will retarget at 10 |
Closing as I'll never use it and a much simpler port to 10 in #254 |
Add new module product_attribute_group to support the grouping of attributes for reuse within product templates.