Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 new product attribute group #79

Closed

Conversation

gdgellatly
Copy link
Contributor

Add new module product_attribute_group to support the grouping of attributes for reuse within product templates.

.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License: AGPL-3

Module name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the actual module name

@gdgellatly gdgellatly force-pushed the 8.0-new-product-attribute-group branch from f359b7b to 396af8f Compare June 24, 2015 03:06
@gdgellatly gdgellatly closed this Jun 24, 2015
@gdgellatly gdgellatly reopened this Jun 24, 2015
@gdgellatly gdgellatly force-pushed the 8.0-new-product-attribute-group branch from 710139b to 396af8f Compare June 25, 2015 04:08
Add new module product_attribute_group to support the grouping of attributes for reuse within product templates.
Fix wrong copyright file
Fix flake8 failures
Fix error in demo data
Fix Readme as per Pedro
Little bit of cleanup and additional demo data
Add tests
@gdgellatly gdgellatly force-pushed the 8.0-new-product-attribute-group branch from 396af8f to 69e536b Compare June 25, 2015 04:16
@gdgellatly
Copy link
Contributor Author

@gurneyalex can you help me. I don't know what to do here. Travis keeps failing, but here are my test results with product_sequence installed on this branch on a test database. I have no idea why it doesn't call the product_sequence overrides on travis to create the codes. (You can see by the long runtime I spent a lot of time in debug ensuring that they are called)

2015-06-25 04:35:57,779 20656 INFO seq_test5 openerp.modules.module: openerp.addons.product_attribute_group.tests.test_attribute_group running tests.
2015-06-25 04:35:57,780 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test03a_action_update_variants_addition (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:42:57,516 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test03b_action_update_variants_addition_overlap (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:23,114 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test03c_action_update_variants_removal (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:36,390 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test03d_action_update_variants_removal_overlap (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:39,056 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test07a_onchange_value_ids_normal (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:41,491 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test07b_onchange_value_ids_abnormal (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:43,900 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test08_onchange_attribute_group_ids (openerp.addons.product_attribute_group.tests.test_attribute_group.EnhancedAttributeGroupTestCase)
2015-06-25 04:48:46,296 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test01_copy_attribute_group (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:46,343 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test02a_unlink_attribute_group_prohibited (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:46,661 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test02b_unlink_attribute_group_normal (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:46,693 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test04_onchange_attribute_value_ids (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:47,086 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test05a_onchange_attribute_id_prohibited (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:47,446 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test05b_onchange_attribute_id (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:47,468 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: test06_constraint_attribute_id (openerp.addons.product_attribute_group.tests.test_attribute_group.SimpleAttributeGroupCase)
2015-06-25 04:48:47,507 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: Ran 14 tests in 769.726s
2015-06-25 04:48:47,507 20656 INFO seq_test5 openerp.addons.product_attribute_group.tests.test_attribute_group: OK

@gdgellatly
Copy link
Contributor Author

@gurneyalex @bwrsandman Hi, I've retested this using the travis commands exactly on a local machine. I think it is a real problem and we might need to change the test script.

Findings
If I run script with product_sequence included in --update - Fails
If I run script with product_sequence included in --update but update module to depend on product_sequence - Pass
If I run script without product_sequence and no dependency (but product_sequence is installed) - Pass

The upshot of this is that I think the test runner should loop over the directories and run --update (1 module) each time. It seems that update does not load the modules to be updated before testing. Even then it is still not ideal, as in theory an installed module could incorrectly cause a test to pass or fail.

@gurneyalex
Copy link
Member

@gdgellatly after a (long) while, rebuilding in travis is almost green : only lint errors remain.

Are you still interested in this PR?

@gdgellatly
Copy link
Contributor Author

@gurneyalex Wow, sorry I missed this, actually I am still really interested but will retarget at 10

@gdgellatly
Copy link
Contributor Author

Closing as I'll never use it and a much simpler port to 10 in #254

@gdgellatly gdgellatly closed this Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants