Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG]product_variant_sale_price #130

Closed
wants to merge 14 commits into from

Conversation

Yakulu
Copy link

@Yakulu Yakulu commented Dec 13, 2018

Basic migration with update in hooks.py and product_product.py files to reflect new database relation names.

Do not hesitate to ask for changes.

sergio-teruel and others added 13 commits December 13, 2018 16:57
Avoid redundant loop
[NEW][8.0] product_variant_sale_price: Improvements

[NEW][8.0] product_variant_sale_price: Fix travis
…ate is created

[product_variant_sale_price] Set minimun fix_price among variants to ensure consistency with the price shown in the shop
…ariants

Steps to reproduce:
- create more than one variant
- change fix_price of one variant

Current behavior:
- lst_price of all variants are changed

Expected behavior:
- lst_price of only selected variant is changed
Currently translated at 100,0% (4 of 4 strings)

Translation: product-variant-11.0/product-variant-11.0-product_variant_sale_price
Translate-URL: https://translation.odoo-community.org/projects/product-variant-11-0/product-variant-11-0-product_variant_sale_price/nl/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@Yakulu Yakulu mentioned this pull request Dec 13, 2018
10 tasks
@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 13, 2018
@@ -61,6 +61,7 @@ Contributors
* Carlos Dauden <carlos.dauden@tecnativa.com>
* Sergio Teruel <sergio.teruel@tecnativa.com>
* Alex Comba <alex.comba@agilebg.com>
* Fabien Bourgeois <fabien@yaltik.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add this to readme/CONTRIBUTORS.rst instead, of this will be auto-removed. See https://github.com/OCA/maintainer-tools/#readme-generator

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done with 65ee7e5

@rlizana
Copy link

rlizana commented Oct 16, 2019

LGTM 👍

@cubells
Copy link
Sponsor Member

cubells commented Oct 29, 2019

superseded by this #160

@pedrobaeza pedrobaeza closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants