[14.0][FIX] product_variant_configurator_manual_creation: faster has_pending_variants computation for products with huge number of variant combinations #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ChrisOForgeFlow, |
giarve
force-pushed
the
14.0
branch
3 times, most recently
from
49f931a
to
ce669d5
Compare
giarve
force-pushed
the
14.0
branch
2 times, most recently
from
df4ffeb
to
7746c09
Compare
…g_variants computation for products with huge number of variant combinations
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A huge number of attribute lines and values creates an infinite loading screen for product template because it calculates a huge amount of combinations. The calculation for this can be skipped for this type of products as they will never be manually created.
The calculation function is similar to the one used by the
productmodule.Should be forward ported to 15.0!