Migrate to 10.0 mig product variant supplierinfo #50
Conversation
|
👍 |
| ('product_id', '=', False), | ||
| ('product_id', '=', product.id), | ||
| ('company_id', '=', procurement.company_id.id), | ||
| company_supplier = self.env['product.supplierinfo'].search( |
There was a problem hiding this comment.
Why do you change this style? Please don't make the diff bigger only for stylistic reasons (squash your commits when restoring this to avoid several diffs).
There was a problem hiding this comment.
Hi @pedrobaeza, I changed this because I got a PEP 8 error (closing bracket does not match indentation)
There was a problem hiding this comment.
But you only need to change... the closing bracket, not the rest.
| <xpath expr="//group[@name='pricing']/parent::group" | ||
| position="after"> | ||
| <separator string="Vendors"/> | ||
| <group name="variant_uppliers" string="Variant Vendors"> |
There was a problem hiding this comment.
s/variant_uppliers/variant_suppliers
mourad-ehm
force-pushed
the
10.0-mig-product_variant_supplierinfo
branch
from
82692a5
to
8254848
Compare
mourad-ehm
force-pushed
the
10.0-mig-product_variant_supplierinfo
branch
from
da2b539
to
c61b396
Compare
|
Hi @pedrobaeza, could you merge this PR please ? |
| @@ -7,24 +7,21 @@ | |||
| <record id="product_normal_form_view_sellers" model="ir.ui.view"> | |||
| <field name="name">product.product.form.sellers</field> | |||
| <field name="model">product.product</field> | |||
| <field name="inherit_id" ref="product.product_normal_form_view"/> | |||
| <field name="inherit_id" ref="product.product_variant_easy_edit_view"/> | |||
There was a problem hiding this comment.
Wouldn't it be better to add new fields in both views: product_variant_easy_edit_view and product_normal_form_view?
@pedrobaeza, @mourad-ehm, what's your point of view?
| @@ -2,7 +2,7 @@ | |||
| # © 2015 Pedro M. Baeza <pedro.baeza@tecnativa.com> | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | |||
|
|
|||
| from openerp import models, fields, api | |||
| from odoo import api, fields, models | |||
|
|
|||
|
|
|||
| class ProductSupplierInfo(models.Model): | |||
There was a problem hiding this comment.
The field product_id should have been removed from this module, because it is native starting from v9 https://github.com/odoo/odoo/blob/9.0/addons/product/product.py#L1272 and still native on v10 https://github.com/odoo/odoo/blob/10.0/addons/product/models/product.py#L631 and the definition here is exactly the same as in the native product module.
No description provided.