New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] project_categ_issue: Migrated to 10.0 #229
Conversation
project_categ_issue/__manifest__.py
Outdated
specific list. | ||
""", | ||
'author': "Daniel Reis,Odoo Community Association (OCA)", | ||
'author': 'Tecnativa, Odoo Community Association (OCA)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Rigoberto, IMO porting a module does not add enough originality in order to grant authorship and teh corresponding copyright.
Please add yourself to the contributors list in the README, but keep the original author in the manifest and code files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add /update README.rst file
project_categ_issue/__manifest__.py
Outdated
{ | ||
'name': 'Per Project Configurable Categorie on Issues', | ||
'summary': 'Projects Issues can have an allowed category list', | ||
'version': '8.0.0.1.0', | ||
'version': '0.1.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.0.1.0.0
class ProjectIssue(models.Model): | ||
_inherit = 'project.issue' | ||
|
||
tag_project = fields.Many2one('project.tags', string='Root Tag for Issues', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Root Tag?
(shorter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the original field names- it eases eases version upgrades.
project_categ_issue/__manifest__.py
Outdated
{ | ||
'name': 'Per Project Configurable Categorie on Issues', | ||
'summary': 'Projects Issues can have an allowed category list', | ||
'version': '8.0.0.1.0', | ||
'version': '0.1.0', | ||
"category": "Project Management", | ||
'description': """\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you should remove the description key from manifest and add a README.rst file following https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst (as of v8)
Please fix runbot and ci |
class ProjectIssue(models.Model): | ||
_inherit = 'project.issue' | ||
|
||
tag_project = fields.Many2one('project.tags', string='Root Tag for Issues', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the original field names- it eases eases version upgrades.
'categ_ids': fields.many2many( | ||
'project.category', string='Tags', | ||
domain="[('id','child_of',issue_categ_id)" | ||
",('id','!=',issue_categ_id)]"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep this domain added to the categ_ids
field: it is usability feature to make large Category/Tag trees more user friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
@Tecnativa