[MIG] project_gtd: migration 8.0 > 10.0 #308

mmequignon · 2017-08-21T10:34:46Z

No description provided.

oca-clabot · 2017-08-21T10:34:49Z

Hey @mmequignon, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@mmequignon (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

sebalix · 2017-08-21T10:37:07Z

Note: @mmequignon is covered by the ABF OSIELL CLA.

gurneyalex · 2017-10-02T16:55:09Z

@sebalix fixed the CLA issue

gurneyalex · 2017-10-02T16:58:28Z

project_gtd/project_gtd.py

+        'Context', size=64, required=True, translate=True)
+    sequence = fields.Integer(
+        'Sequence',
+        help=("Gives the sequence order when displaying a list of contexts."),


if the line is short enough, you can get rid of the ( )

gurneyalex · 2017-10-02T17:03:12Z

This looks really nice.

oca-clabot · 2017-10-02T21:23:50Z

Hey @mmequignon,
We acknowledge that the following users have signed our Contributor License Agreement:

@mmequignon

Appreciation of efforts,
OCA CLAbot

Jerther

I made some improvement suggestions. Nothing critical really.

Jerther · 2017-11-09T14:56:41Z

project_gtd/__manifest__.py

-performing those tasks.
-    """,
-    'author': "OpenERP SA,Odoo Community Association (OCA)",
+    'author': "OpenERP SA, Odoo Community Association (OCA), ABF OSIELL",


OpenERP --> Odoo

Jerther · 2017-11-09T17:16:05Z

project_gtd/project_gtd.py

+    def fields_view_get(self, view_id=None, view_type='form', toolbar=False,
+                        submenu=False):
+        res = super(ProjectTask, self).fields_view_get(
+            view_id, view_type, toolbar=toolbar, submenu=submenu)


Arguments should be simplified with *args and **kwargs

@Jerther sorry?

Since all arguments are solely used in the super call, I think it'd be safer and cleaner to write:

def fields_view_get(self, *args, **kwargs): res = super(ProjectTask, self).fields_view_get(*args, **kwargs)

Jerther · 2017-11-09T17:21:26Z

project_gtd/project_gtd.py

+# Copyright 2017 ABF OSIELL <http://osiell.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import fields, models, api, tools


imported lines should be alphabetically sorted

Jerther · 2017-11-09T17:22:11Z

project_gtd/wizard/project_gtd_empty.py


-from openerp.osv import fields, osv
-from openerp.tools.translate import _
+from odoo import fields, models, api, exceptions


imported lines should be alphabetically sorted

Jerther · 2017-11-09T17:22:29Z

project_gtd/wizard/project_gtd_fill.py


-from openerp.osv import fields, osv
+from odoo import fields, models, api


imported lines should be alphabetically sorted

dreispt

Made a few comment to fix.

dreispt · 2017-11-22T10:43:50Z

project_gtd/project_gtd.py

    _order = "sequence, name"

+    name = fields.Char(
+        'Context', size=64, required=True, translate=True)


It is current practice to remove the size attribute from Chars

dreispt · 2017-11-22T10:45:26Z

project_gtd/project_gtd.py

+    def fields_view_get(self, view_id=None, view_type='form', toolbar=False,
+                        submenu=False):
+        res = super(ProjectTask, self).fields_view_get(
+            view_id, view_type, toolbar=toolbar, submenu=submenu)


@Jerther sorry?

dreispt · 2017-11-22T10:46:54Z

project_gtd/project_gtd_view.xml

    <record model="ir.ui.view" id="view_gtd_context_tree">
        <field name="name">project.gtd.context.tree</field>
        <field name="model">project.gtd.context</field>
        <field name="arch" type="xml">
-            <tree string="Context">
+            <tree name="Context">


Isnt't "string" correct? Anyway, i don't think these attributes are really useful.

dreispt · 2017-11-22T10:47:10Z

project_gtd/project_gtd_view.xml

@@ -16,7 +15,7 @@
        <field name="name">project.gtd.context.form</field>
        <field name="model">project.gtd.context</field>
        <field name="arch" type="xml">
-            <form string="Context" version="7.0">
+            <form name="Context" version="7.0">


I believe you can remove the "7.0"

dreispt · 2017-11-22T10:49:22Z

project_gtd/wizard/project_gtd_fill.py

-        self.pool.get('project.task').write(
-            cr, uid, data[0]['task_ids'],
-            {'timebox_id': data[0]['timebox_to_id'][0]})
+        self.task_ids.write({'timebox_id': self.timebox_to_id.id})
        return {'type': 'ir.actions.act_window_close'}

 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:


Please remove

mmequignon · 2017-12-22T10:47:36Z

It seems that tests are failing because of project_closing module.

Travis traceback
(most recent call last):
File "/home/travis/build/OCA/project/project_closing/tests/test_project.py", line 40, in test_analytic_toggle_active
self.assertFalse(self._analytic1.active)
AssertionError: True is not false

I don't know what to do about this.

mmequignon · 2018-02-15T20:38:24Z

Since project_closing have been removed from project, tests are now ok.
Is there anything else to fix ?

sebalix · 2018-02-16T10:48:16Z

Squash your commits please.

mmequignon · 2018-02-16T11:27:05Z

Yes, that's done, thank you !

SalahAdDin · 2018-06-26T14:48:18Z

It seems very nice to 11.0.

gurneyalex approved these changes Oct 2, 2017

View reviewed changes

gurneyalex added this to the 10.0 milestone Oct 2, 2017

mmequignon force-pushed the 10.0-mig-project_gtd branch from 1b190cb to ff2f6de Compare October 2, 2017 21:25

rafaelbn added the needs review label Oct 15, 2017

Jerther reviewed Nov 9, 2017

View reviewed changes

dreispt reviewed Nov 22, 2017

View reviewed changes

mmequignon force-pushed the 10.0-mig-project_gtd branch from 95a4815 to bce01b8 Compare December 22, 2017 11:14

sebalix approved these changes Feb 16, 2018

View reviewed changes

[MIG] project_gtd: migration 8.0 > 10.0

9d5e185

mmequignon force-pushed the 10.0-mig-project_gtd branch from bce01b8 to 9d5e185 Compare February 16, 2018 11:26

fuentes73 approved these changes Jun 22, 2018

View reviewed changes

pedrobaeza merged commit 9ba642c into OCA:10.0 Jun 22, 2018

pedrobaeza mentioned this pull request Jun 22, 2018

Migration to version 10.0 #196

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] project_gtd: migration 8.0 > 10.0 #308

[MIG] project_gtd: migration 8.0 > 10.0 #308

mmequignon commented Aug 21, 2017

oca-clabot commented Aug 21, 2017

sebalix commented Aug 21, 2017

gurneyalex commented Oct 2, 2017

gurneyalex Oct 2, 2017

gurneyalex commented Oct 2, 2017

oca-clabot commented Oct 2, 2017

Jerther left a comment

Jerther Nov 9, 2017

Jerther Nov 9, 2017

dreispt Nov 22, 2017

Jerther Nov 22, 2017

Jerther Nov 9, 2017

Jerther Nov 9, 2017

Jerther Nov 9, 2017

dreispt left a comment

dreispt Nov 22, 2017

dreispt Nov 22, 2017

dreispt Nov 22, 2017

dreispt Nov 22, 2017

dreispt Nov 22, 2017

mmequignon commented Dec 22, 2017

mmequignon commented Feb 15, 2018 •

edited

sebalix commented Feb 16, 2018

mmequignon commented Feb 16, 2018

SalahAdDin commented Jun 26, 2018


		from openerp.osv import fields, osv
		from odoo import fields, models, api

[MIG] project_gtd: migration 8.0 > 10.0 #308

[MIG] project_gtd: migration 8.0 > 10.0 #308

Conversation

mmequignon commented Aug 21, 2017

oca-clabot commented Aug 21, 2017

sebalix commented Aug 21, 2017

gurneyalex commented Oct 2, 2017

Choose a reason for hiding this comment

gurneyalex commented Oct 2, 2017

oca-clabot commented Oct 2, 2017

Jerther left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreispt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmequignon commented Dec 22, 2017

mmequignon commented Feb 15, 2018 • edited

sebalix commented Feb 16, 2018

mmequignon commented Feb 16, 2018

SalahAdDin commented Jun 26, 2018

mmequignon commented Feb 15, 2018 •

edited