[11.0][ADD] project_timeline_critical_path: Highlight critical path in task timeline view #421
Conversation
|
Nice feature! |
| 'name': 'Test1' | ||
| }) | ||
| project2 = project_obj.create({ | ||
| 'name': 'Test2' |
There was a problem hiding this comment.
Tests are failing because of the way module project_key generates keys for a project.
The generated keys for 'Test1' and 'Test2' are both equal to 'TES', and that is causing the issue because of the uniqueness constraint on the keys.
I you give a different name to this project, so for example instead of 'Test2' you name it something like 'Other Test', the tests will pass.
| # Copyright 2018 Onestein | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import models, fields, api |
There was a problem hiding this comment.
Could you sort imports alphabetically? https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#imports
| # Copyright 2018 Onestein | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import models, api |
There was a problem hiding this comment.
Please sort imports alphabetically
|
|
||
| <odoo> | ||
| <record id="res_config_settings_view_form" model="ir.ui.view"> | ||
| <field name="name">res_config_settings_view_form</field> |
There was a problem hiding this comment.
You can remove <field name="name" ... since the system will generate the name automatically
|
@OCA/community-maintainers could you please take a look at the pylint failure below? Yesterday it was working fine, today not anymore. It seems to me a regression. |
|
Yes, it's because of this PR: OCA/pylint-odoo#210 (comment) |
|
Fixed in OCA/pylint-odoo@f092c23. I have relaunched a build |
|
I'm afraid it's not the good one. I continue checking. |
|
This is the good patch: OCA/maintainer-quality-tools@c80d1d0 |
[FIX] Flake [ADD] Roadmap [FIX] ImportError [ADD] criticalpath to travis [FIX] Tests and small issues
tarteo
force-pushed
the
11-project-timeline-critical-path
branch
from
71813c9
to
feb44e9
Compare
|
Can this be merged? Or does it needs 3 reviews? |
|
I think this one can be merged ... |
…n task timeline view (OCA#421)
Calculates the critical path using a simple library (criticalpath) and highlight it in the timeline view.
Like this:
The red line is the critical path.
You can change the way the calculation is done to lead time or planned hours.