Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] project_deadline #569

Merged
merged 1 commit into from Sep 27, 2019
Merged

[12.0][ADD] project_deadline #569

merged 1 commit into from Sep 27, 2019

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Aug 21, 2019 •
edited

Currently the project_timeline shows the hidden date and date_start on the project form view. It's a problem for customers who don't want the timeline view (yes they exists) but want to specify deadlines on projects. That's why I created an extra module project_deadline. With this PR I also changed the dependencies in the project_timeline module.

Features:

  • Change start date and deadline of projects
  • Shows the deadline in the project kanban view
  • Show the start date and deadline of the project on the task form view

@pedrobaeza pedrobaeza added this to the 12.0 milestone Aug 21, 2019
@pedrobaeza
Copy link
Member

I don't agree on changing the dependencies of project_timeline. What you can do is to overwrite fields_view_get in both modules, and add by code the fields in the view if they don't exist yet.

@tarteo
Copy link
Member Author

tarteo commented Aug 22, 2019 •
edited

@pedrobaeza I understand your point. Let's see what other think of it. Thanks.
IMO the view in another module + dependency in others is not a problem. To migrate the module it'll take not much time.

@pedrobaeza
Copy link
Member

@tarteo this doesn't depend on what others think. The module has been merged in the branch since a long. You can't break all the instances that have is installed forcing a new dependency that might not even be in their addons path (if they don't add massively all the folder, like my company does).

Then, the only option for having this accepted is the way I'm telling you to do.

@tarteo
Copy link
Member Author

tarteo commented Aug 22, 2019

Sure @pedrobaeza.

@tarteo tarteo force-pushed the 12-project-deadline branch 2 times, most recently from c28062d to 58c7c65 Compare August 22, 2019 08:04
@tarteo
Copy link
Member Author

tarteo commented Aug 22, 2019 •
edited

@pedrobaeza Are you happy with this? I moved it to fields_view_get. There are no tests yet, I'll make them when you're happy to prevent wasting time.

@pedrobaeza
Copy link
Member

Yes, thanks!

alexey-pelykh
alexey-pelykh reviewed Aug 30, 2019
View reviewed changes
project_deadline/__init__.py
@@ -0,0 +1 @@
from . import models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer to have license in these files, yet that's just a comment

alexey-pelykh
alexey-pelykh approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rafaelbn
Copy link
Member

rafaelbn commented Sep 5, 2019

Hi @tarteo , could you add an Usage section in order to test it? Let me know thanks!

@tarteo
[ADD] project_deadline
9dcd615 
[FIX] Flake

[ADD] Use fields_view_get

[ADD] Use fields_view_get

[ADD] Tests

[FIX] Quick create form bug

[ADD] usage description
@tarteo
Copy link
Member Author

tarteo commented Sep 18, 2019

@rafaelbn Hi, I've added a usage section in the readme.

@tarteo
Copy link
Member Author

tarteo commented Sep 27, 2019

@rafaelbn Can you retest it, please?

@rafaelbn
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-569-by-rafaelbn-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 27, 2019
@OCA-git-bot
Merge PR #569 into 12.0
2838b88 
Signed-off-by rafaelbn
@OCA-git-bot OCA-git-bot merged commit 9dcd615 into OCA:12.0 Sep 27, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 790501e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tarteo @pedrobaeza @rafaelbn @OCA-git-bot @alexey-pelykh