project template Migration to 13.0 #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @patrickrwilson, |
dalonsod
suggested changes
May 18, 2020
emagdalenaC2i
suggested changes
May 18, 2020
ghost
requested review from
emagdalenaC2i
approved these changes
May 22, 2020
|
OK @okuryan I'll take a look as soon as possible. This PR has three approvals anyway, it looks 👍 |
|
@dalonsod , but because you are only one who haven't approved. This PR is not automatically marked as approved as result nobody can merge it for a month =) |
* [ADD] project_task_dependencies [FIX] Removed bullet point * [FIX] Module name and circular depedencies * [FIX] NewId issue * [FIX] Test names
Currently translated at 100.0% (8 of 8 strings) Translation: project-11.0/project-11.0-project_task_dependency Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_dependency/fr/
Currently translated at 100,0% (8 of 8 strings) Translation: project-11.0/project-11.0-project_task_dependency Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_dependency/pt_BR/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Depending tasks are very expensive to be computed, so we remove them from the form view as they are useless. We need also to split the compute method for each field for not suffering the same problem with the needed field. Any way, this doesn't add anything, as each field is computed isolatedly. Finally, a bit of tweaking has been done for improving a bit computation of dependencies.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Adding new Project Template Module [FIX] PEP8 Errors Revert "[FIX] PEP8 Errors" This reverts commit 90f9cd9. [FIX] Fixed PEP8 Formatting First upload tests showed some lint issues which this commit has the fixes for. [FIX] Fixed LINT Issue Removed unreachable code that was not needed. [FIX] RunBot Warning Fixed runbot warning about @Class to hasclass [UPD] Suggested Changes Updated based on suggested changes on other submitted modules. [UPD] Manifest and Readme Updated Manifest and Readme based on comments on other module pr's. [UPD] Suggested Changes Updated code based on suggested code changes from reviewer. [FIX] Creation Error Fixed create project error when creating project via configuration/projects menu [UPD] Menu and Bool Change Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions) [UPD] Kanban Menu Removed button, added link to kanban menu. Start of tests [UPD] Remove project_milestone code Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/
There is an error if the template name gets modified so needed to add a new else statement for the new_name.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/
Currently translated at 85.7% (6 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/
[DEL] total_planned_hours [ADD] increase test coverage [ADD] formating [DEL] setup.py from project_template [MDI] version number
dalonsod
suggested changes
Jun 15, 2020
There was a problem hiding this comment.
@dalonsod , but because you are only one who haven't approved. This PR is not automatically marked as approved as result nobody can merge it for a month =)
OK, I didn't know it, for other repositories I collaborate in, two approvals are enough to be marked as approved, and a missing review are not blocking, I think... I'll take in account for future reviews.
Code reviewed,
setup/project_template/odoo/addons/project_templateis still part of the commit files and it should be removed IMO.README.rstis not coherent withCONTRIBUTORS.rstfile.- I don't know if the last commit, probably originated with a recent rebase ("Merge branch '13.0' into 13.0-mig-project_template") is already correct.
- Maybe administrative commits for v12 should be squashed.
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.