[MIG] project_template: Migration to 13.0 #684
Conversation
Adding new Project Template Module [FIX] PEP8 Errors Revert "[FIX] PEP8 Errors" This reverts commit 90f9cd9. [FIX] Fixed PEP8 Formatting First upload tests showed some lint issues which this commit has the fixes for. [FIX] Fixed LINT Issue Removed unreachable code that was not needed. [FIX] RunBot Warning Fixed runbot warning about @Class to hasclass [UPD] Suggested Changes Updated based on suggested changes on other submitted modules. [UPD] Manifest and Readme Updated Manifest and Readme based on comments on other module pr's. [UPD] Suggested Changes Updated code based on suggested code changes from reviewer. [FIX] Creation Error Fixed create project error when creating project via configuration/projects menu [UPD] Menu and Bool Change Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions) [UPD] Kanban Menu Removed button, added link to kanban menu. Start of tests [UPD] Remove project_milestone code Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/
There is an error if the template name gets modified so needed to add a new else statement for the new_name.
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/
Currently translated at 85.7% (6 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/
Currently translated at 100.0% (7 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/
Currently translated at 14.3% (1 of 7 strings) Translation: project-12.0/project-12.0-project_template Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/it/
|
Hi @patrickrwilson, |
ghost
mentioned this pull request
There was a problem hiding this comment.
Hi @Alfadil
It seems that it exists an incompatibility with project_key module. I describe the behaviour:
1- Open the options of a project and set "is template" checkbox to True.
2- Once the project has been defined as a template, click to "Create project from template". It doesn't matter if you do that by the form view or the Kanban view. It will work properly.
3- Try to create a second project using the same template as before: An error occurs as a restriction popup will tell the user that "Project key must be unique".
If you create one project from a template it is working fine. If you try to create a second project using the same template, user is going to be restricted by the unique key.
Could you check?
Thanks!
|
hi @HaraldPanten |
ghost
requested a review
from
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at a03fe15. Thanks a lot for contributing to OCA. ❤️ |
No description provided.