Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_line_procurement_group: Migration to 16.0 #1806

Merged

Conversation

lehoangan
Copy link
Contributor

No description provided.

grindtildeath and others added 30 commits March 15, 2023 14:19
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_line_procurement_group
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_line_procurement_group/zh_CN/
and a service was included. The service does not create a stock move.
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_line_procurement_group
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_line_procurement_group/fr/
This reverts commit e2cdc23405318a2af0bc08405013917819bfd4d6.
…t procurement group

This fix restore the behaviour found in the 12.0 implementation of this module.
Without it, an existing purchase line with a procurement group can be merged with a procurement without group, while the reverse is not true.
@lehoangan lehoangan mentioned this pull request Mar 16, 2023
51 tasks
@lehoangan lehoangan changed the title [16.0][MIG] purchase_line_procurement_group [16.0][MIG] purchase_line_procurement_group: Migration to 16.0 Mar 21, 2023
@quannguyen1560
Copy link
Contributor

@lehoangan, I think you should add yourself in the contributor,

@lehoangan
Copy link
Contributor Author

I addes it anlh@trobz.com

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Contributor

@quannguyen1560 quannguyen1560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1806-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0190a7b into OCA:16.0 Apr 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a5aa660. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet