Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_request_department: module migration #1892

Open
wants to merge 57 commits into
base: 16.0
Choose a base branch
from

Conversation

JanQubiQ
Copy link

@JanQubiQ JanQubiQ commented Jun 5, 2023

No description provided.

gmeficent and others added 15 commits June 5, 2023 16:56
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_request_department
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_request_department/pt_BR/
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/de/
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/zh_CN/
@JanQubiQ JanQubiQ changed the title [16.0][MIG] purchase request department: module migration [16.0][MIG] purchase_request_department: module migration Jun 5, 2023
Copy link
Contributor

@flalexg flalexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JanQubiQ, the code looks well. Nevertheless, could you change the setUp function to the setUpClass? In the v16 it's mrecommended to use this class. Thank you.

@JanQubiQ JanQubiQ mentioned this pull request Jun 6, 2023
51 tasks
Copy link
Contributor

@flalexg flalexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ps-tubtim and others added 24 commits June 7, 2023 17:12
Currently translated at 21.7% (5 of 23 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_type/fr_FR/
Currently translated at 96.1% (25 of 26 strings)

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_type/it/
Currently translated at 42.3% (11 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/pt_BR/
Currently translated at 96.1% (25 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 96.1% (25 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 96.1% (25 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 50.0% (13 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/sl/
Currently translated at 96.1% (25 of 26 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
…ners to be selected in the purchases orders.

TT33223
…contact form to show only if purchase_selectable is checked.

TT33933
@JanQubiQ JanQubiQ force-pushed the 16.0-mig-purchase_request_department branch from 70b493d to 9d316fd Compare June 7, 2023 15:14
Copy link
Contributor

@hugo-cordoba hugo-cordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florenciafrigieri2
Copy link
Contributor

@JanQubiQ Hello! Are you going to move on with this PR? Thanks in advance!

@nicomacr
Copy link
Contributor

nicomacr commented Aug 8, 2023

Hello @JanQubiQ could you fix the conflict in this PR?

Copy link

@andyjquijada andyjquijada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JanQubiQ , The code LGTM. Could you fix de conflicts?
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet