-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] purchase_request_department: module migration #1892
base: 16.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_request_department Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_request_department/pt_BR/
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/it/
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/de/
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_request_department Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_request_department/zh_CN/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JanQubiQ, the code looks well. Nevertheless, could you change the setUp function to the setUpClass? In the v16 it's mrecommended to use this class. Thank you.
purchase_request_department/tests/test_purchase_request_department.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_request_department Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_request_department/it/
Add a type of purchase orders
Currently translated at 21.7% (5 of 23 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_type/fr_FR/
Currently translated at 96.1% (25 of 26 strings) Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_type/it/
Currently translated at 42.3% (11 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/pt_BR/
Currently translated at 96.1% (25 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 96.1% (25 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 96.1% (25 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
Currently translated at 50.0% (13 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/sl/
Currently translated at 96.1% (25 of 26 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_type Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_type/it/
…ners to be selected in the purchases orders. TT33223
…d field from purchase order. TT33223
…contact form to show only if purchase_selectable is checked. TT33933
70b493d
to
9d316fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JanQubiQ Hello! Are you going to move on with this PR? Thanks in advance! |
Hello @JanQubiQ could you fix the conflict in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JanQubiQ , The code LGTM. Could you fix de conflicts?
Thanks in advance!
No description provided.