Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [ADD] purchase_order_partner_manual_rank #2062

Merged

Conversation

renda-dev
Copy link
Contributor

Simple module that adds a filter on purchase order vendor to show only partners that are suppliers.

@@ -0,0 +1,2 @@
This module adds a filter on purchase order vendor
to show only partners that are suppliers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to show only partners that are suppliers.
to show only partners that are suppliers as per module partner_manual_rank behavior.

Copy link

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review ok

@aleuffre aleuffre force-pushed the 14.0-add-purchase_order_partner_manual_rank branch from 5a4908e to b58a38f Compare October 30, 2023 11:28
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@aleuffre aleuffre force-pushed the 14.0-add-purchase_order_partner_manual_rank branch from b58a38f to 9af8bd7 Compare October 30, 2023 15:50
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@OCA/procurement-purchase-maintainers merge? :)

@francesco-ooops
Copy link
Contributor

@yajo could you please take a look? :)

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2062-by-yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e01a852 into OCA:14.0 Nov 3, 2023
15 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b25580b. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-add-purchase_order_partner_manual_rank branch November 6, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants