new module purchase extended #25

lepistone · 2014-10-07T10:16:29Z

see __openerp__.py for details. Thanks!

(../generic-addons/ rev 10.1.1)

… methods, licenses, ... (../generic-addons/ rev 10.1.3)

…ntation for brackets (pep-8) (../generic-addons/ rev 10.2.1)

…er to replace the only attribute to modify (../generic-addons/ rev 10.2.2)

…es; use orm.Model rather than osv.Model (../generic-addons/ rev 10.2.3)

(../generic-addons/ rev 10.2.4)

(../generic-addons/ rev 10.2.5)

…fy the reading flow (../generic-addons/ rev 10.2.6)

(../generic-addons/ rev 10.2.18)

[IMP] improved bid workflow (../generic-addons/ rev 15.5.1)

…ate cancelled rfq/po (../generic-addons/ rev 15.5.3)

(../generic-addons/ rev 15.5.9)

(../generic-addons/ rev 15.5.10)

(../generic-addons/ rev 15.5.11)

…ing bids in case of open call for bids + add check call for bids has lines when confirming (../generic-addons/ rev 15.5.13)

(../generic-addons/ rev 15.5.14)

(../generic-addons/ rev 15.5.15)

…osv.Model, osv.osv_memory by osv.TransientModel (../generic-addons/ rev 15.5.16)

(../generic-addons/ rev 15.5.17)

(../generic-addons/ rev 15.5.20)

… launching a wizard (../generic-addons/ rev 15.5.21)

…ted workflow (../generic-addons/ rev 15.5.26)

(../generic-addons/ rev 15.5.28)

… copy (../generic-addons/ rev 15.5.29)

(../generic-addons/ rev 15.5.30)

(../generic-addons/ rev 15.5.32)

… we need to take care of when changing the PO line to ensure we don't change the price (onchange_product_id)' (../generic-addons/ rev 29.1.17)

(../generic-addons/ rev 29.1.23)

…l for bids process (../generic-addons/ rev 29.2.1)

…e. Please see nested history for details (../generic-addons/ rev 33)

the onchange warehouse -> address became on picking type -> address The onchange address -> warehouse was removed. Note that in situations other that dropshipping the destination address is hidden. (see odoo/odoo#2950 )

yvaucher · 2014-10-07T12:26:01Z

👍

max3903 · 2014-10-07T16:12:43Z

I would suggest to rename the module because any module is "extending" another.

Few ideas that pops up reading the description:

purchase_type
purchase_order_rfq_type

👎

gurneyalex · 2014-10-07T19:49:17Z

purchase_extended/__openerp__.py

+with the right naming.
+
+
+In the scope of internation transactions, some fields have been added:


s/internation/international/

gurneyalex · 2014-10-07T19:50:39Z

I have nothing against renaming to something more descriptive.

purchase_rfq_bid_workflow ?

@jgrandguillaume any suggestion?

jgrandguillaume · 2014-10-08T07:46:19Z

👍 for purchase_rfq_bid_workflow => it reflects what we do here, clarifying the workflow for bid, rfq and po.

lepistone · 2014-10-08T07:52:25Z

@jgrandguillaume and others: can you suggest a new name for purchase_requisition_extended as well? PR not ready yet, code here: https://github.com/lepistone/purchase-workflow/tree/8.0-add-purchase_requisition_extended/purchase_requisition_extended

yvaucher · 2014-10-08T08:03:58Z

👍 for the renaming.

By the way it would be the right time to add a summary to __openerp__.py

yvaucher · 2014-10-08T08:30:08Z

For the name of second module you could name it purchase_requisition_bid_encoding or purchase_requisition_bid_selection.

lepistone · 2014-10-08T13:09:05Z

I renamed the module as suggested. I fixed the typos reported by @gurneyalex. Thanks!

coveralls · 2014-10-08T13:27:31Z

Coverage increased (+38.35%) when pulling 0ac8e74 on lepistone:8.0-add-purchase-extended into 537b2e4 on OCA:8.0.

max3903 · 2014-10-08T13:33:00Z

👍

lepistone · 2014-10-08T13:35:20Z

thanks for reviewing!

new module purchase_rfq_bid_workflow

refactor to inherit from purchase.order

jbaudoux and others added 30 commits September 29, 2014 10:43

[ADD] purchase and purchase requisition generic improvements

7b35078

(../generic-addons/ rev 10.1.1)

[REVIEW] reviewed feature branch: pep8, styling, rewrite of intricate…

1dc07ad

… methods, licenses, ... (../generic-addons/ rev 10.1.3)

[FIX] wrong company name, missing license, missing coding, wrong inde…

c7d9f4d

…ntation for brackets (pep-8) (../generic-addons/ rev 10.2.1)

[IMP] do not override completely the warehouse_id field, instead pref…

17c8c68

…er to replace the only attribute to modify (../generic-addons/ rev 10.2.2)

[FIX] pep8: space after commas, spaces around operators, cut long lin…

13e3c75

…es; use orm.Model rather than osv.Model (../generic-addons/ rev 10.2.3)

[FIX] empty list evaluates as False

56f3184

(../generic-addons/ rev 10.2.4)

[FIX] intricated condition

f8c700c

(../generic-addons/ rev 10.2.5)

[FIX] return early when the condition is evaluated to False to simpli…

048d583

…fy the reading flow (../generic-addons/ rev 10.2.6)

[FIX] unclosed literal

764b3c6

(../generic-addons/ rev 10.2.18)

[IMP] moved purchase modifications to the right module

6443797

[IMP] improved bid workflow (../generic-addons/ rev 15.5.1)

[FIX]purchase_extended: use rfq/po type in menu actions to differenti…

553a208

…ate cancelled rfq/po (../generic-addons/ rev 15.5.3)

[IMP]purchase_extended, purchase_requisition: documentation

f0b24ee

(../generic-addons/ rev 15.5.9)

[ADD]purchase: reason for cancellation + few fixes

69b5feb

(../generic-addons/ rev 15.5.10)

[FIX]purchase: repair after rebase + fix draftpo to cancel

bbdfcfc

(../generic-addons/ rev 15.5.11)

[IMP]purchase, purchase_requisition: add state draft bid for register…

9638c50

…ing bids in case of open call for bids + add check call for bids has lines when confirming (../generic-addons/ rev 15.5.13)

[FIX]purchase: renamed cancelled into canceled

33ebbc7

(../generic-addons/ rev 15.5.14)

[FIX]purchase: fixed cancel reason unlink method

d80537d

(../generic-addons/ rev 15.5.15)

[FIX]purchase: replaced osv.except_osv by orm.except_orm, osv.osv by …

bb1fa35

…osv.Model, osv.osv_memory by osv.TransientModel (../generic-addons/ rev 15.5.16)

[FIX] pep8

f1d6e94

(../generic-addons/ rev 15.5.17)

[ADD] YML tests + few fixes

7a559b1

(../generic-addons/ rev 15.5.20)

[FIX]purchase: need to remove active_model/id/ids from context before…

37d15bf

… launching a wizard (../generic-addons/ rev 15.5.21)

[FIX]purchase: on_change product must manage price properly with upda…

3b8efb2

…ted workflow (../generic-addons/ rev 15.5.26)

[FIX]purchase: noupdate for cancel reason data

47e0b27

(../generic-addons/ rev 15.5.28)

[FIX]purchase: context shouldn't be modified directly without doing a…

34f8ab1

… copy (../generic-addons/ rev 15.5.29)

[FIX]purchase: invoice button should not be visible on draft rfq/bid/po

f3fd389

(../generic-addons/ rev 15.5.30)

[FIX]import, orm

c3b82c5

(../generic-addons/ rev 15.5.32)

[FIX]purchase: As a new state draftbid has been introduced on the PO,…

dad4b5c

… we need to take care of when changing the PO line to ensure we don't change the price (onchange_product_id)' (../generic-addons/ rev 29.1.17)

[FIX] Remove context from tag record as it is not supported

1375ad4

(../generic-addons/ rev 29.1.23)

[ADD]purchase_requisition: yml test file of a complete restricted cal…

b2a719d

…l for bids process (../generic-addons/ rev 29.2.1)

[MRG] Major modification of procurement workflow for purchase and sal…

a4b21d1

…e. Please see nested history for details (../generic-addons/ rev 33)

lepistone added 10 commits October 1, 2014 11:27

enable the last test file, and make it green

bae55bb

remove duplicated test, improve context

546bca4

fix duplication, and test it

9bf98c9

add assertions on the cancel reason wizard

1584bce

remove unused method

440b848

fix and test the "bid encoded" wizard

323221f

cleanup cancel reason unlink

30f4b27

update copyright and version

2221d9f

port onchanges

7101fae

the onchange warehouse -> address became on picking type -> address The onchange address -> warehouse was removed. Note that in situations other that dropshipping the destination address is hidden. (see odoo/odoo#2950 )

travis: add server-tools for web_context_tunnel

b60d675

gurneyalex reviewed Oct 7, 2014
View reviewed changes

lepistone added 2 commits October 8, 2014 15:05

fix typos

493ffd7

rename purchase_extended -> purchase_rfq_bid_workflow

0ac8e74

add summary to manifest

bb8f551

lepistone added a commit that referenced this pull request Oct 8, 2014

Merge pull request #25 from lepistone/8.0-add-purchase-extended

f62db97

new module purchase_rfq_bid_workflow

lepistone merged commit f62db97 into OCA:8.0 Oct 8, 2014

lepistone deleted the 8.0-add-purchase-extended branch October 8, 2014 13:36

dnplkndll pushed a commit to Kencove/purchase-workflow that referenced this pull request Oct 11, 2021

Merge pull request OCA#25 from ForgeFlow/14.0-purchase_return-inherit

e0a4caf

refactor to inherit from purchase.order

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new module purchase extended #25

new module purchase extended #25

lepistone commented Oct 7, 2014

yvaucher commented Oct 7, 2014

max3903 commented Oct 7, 2014

gurneyalex Oct 7, 2014

gurneyalex commented Oct 7, 2014

jgrandguillaume commented Oct 8, 2014

lepistone commented Oct 8, 2014

yvaucher commented Oct 8, 2014

yvaucher commented Oct 8, 2014

lepistone commented Oct 8, 2014

coveralls commented Oct 8, 2014

max3903 commented Oct 8, 2014

lepistone commented Oct 8, 2014

		with the right naming.


		In the scope of internation transactions, some fields have been added:

new module purchase extended #25

new module purchase extended #25

Conversation

lepistone commented Oct 7, 2014

yvaucher commented Oct 7, 2014

max3903 commented Oct 7, 2014

gurneyalex Oct 7, 2014

Choose a reason for hiding this comment

gurneyalex commented Oct 7, 2014

jgrandguillaume commented Oct 8, 2014

lepistone commented Oct 8, 2014

yvaucher commented Oct 8, 2014

yvaucher commented Oct 8, 2014

lepistone commented Oct 8, 2014

coveralls commented Oct 8, 2014

max3903 commented Oct 8, 2014

lepistone commented Oct 8, 2014