9.0 mig purchase fiscal position update #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 11, 2016
|
|
||
| @api.onchange('fiscal_position_id') | ||
| def onchange_fiscal_position_id(self): | ||
| for line in self.order_line: |
There was a problem hiding this comment.
Do:
for line in self.order_line:
temp_line = line.new(line._convert_to_write(line._cache))
temp_line.onchange_product_id()
line.taxes_id = temp_line.taxes_id
There was a problem hiding this comment.
This way is not working, and using cache is not direct, so it's more clear do like @alexis-via on #280
pedrobaeza
requested changes
Oct 11, 2016
|
Check also Travis status |
pedrobaeza
reviewed
Oct 15, 2016
|
|
||
| @api.onchange('fiscal_position_id') | ||
| def fiscal_position_change(self): | ||
| '''Function executed by the on_change on the fiscal_position_id field |
There was a problem hiding this comment.
Double quote instead of simple for docstring according PEP257
|
Tests added |
|
Travis is still red |
…angelmoya/purchase-workflow into 9.0-mig-purchase_fiscal_position_update
pedrobaeza
approved these changes
Nov 16, 2016
|
As this one is the same as 10.0 version and it has another author, I merge both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.