Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] [mig] procurement_purchase_no_grouping: Migration to v10.0 #448

Merged

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel force-pushed the 10.0-mig-procurement_purchase_no_grouping branch from fdd9b53 to 1be6810 Compare September 5, 2017 16:28
make_po_conditions = {
'partner_id', 'state', 'picking_type_id', 'company_id',
'dest_address_id',
}
# Restrict the empty return for these conditions
if (context and context.get('grouping', 'standard') == 'order' and
if (self._context and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use self.env.context

# Restrict the empty return for these conditions
if (context and context.get('grouping', 'standard') == 'line' and
if (self._context and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.env.context

@pedrobaeza
Copy link
Member

@carlosdauden please review

Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after replace _context by self.env.context
Test OK

@sergio-teruel
Copy link
Contributor Author

@pedrobaeza @carlosdauden Changes done.

@pedrobaeza pedrobaeza force-pushed the 10.0-mig-procurement_purchase_no_grouping branch from 277cf99 to 8d6bb74 Compare September 21, 2017 00:46
@pedrobaeza pedrobaeza merged commit 6643627 into OCA:10.0 Sep 21, 2017
@pedrobaeza pedrobaeza deleted the 10.0-mig-procurement_purchase_no_grouping branch September 21, 2017 00:47
@pedrobaeza pedrobaeza mentioned this pull request Sep 21, 2017
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants