-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0] [mig] procurement_purchase_no_grouping: Migration to v10.0 #448
[10.0] [mig] procurement_purchase_no_grouping: Migration to v10.0 #448
Conversation
fdd9b53
to
1be6810
Compare
make_po_conditions = { | ||
'partner_id', 'state', 'picking_type_id', 'company_id', | ||
'dest_address_id', | ||
} | ||
# Restrict the empty return for these conditions | ||
if (context and context.get('grouping', 'standard') == 'order' and | ||
if (self._context and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use self.env.context
# Restrict the empty return for these conditions | ||
if (context and context.get('grouping', 'standard') == 'line' and | ||
if (self._context and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.env.context
@carlosdauden please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after replace _context by self.env.context
Test OK
@pedrobaeza @carlosdauden Changes done. |
…ion to avoid problems on other searches made on same method
277cf99
to
8d6bb74
Compare
cc @Tecnativa