Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] migrate module procurement_batch_generator #483

Closed
wants to merge 31 commits into from

Conversation

alexis-via
Copy link
Contributor

No description provided.

oca-transbot and others added 30 commits December 14, 2017 11:09
Convert YAML test to unittest
@pedrobaeza
Copy link
Member

Please squash all "OCA Transbot..." commits that are adjacent together

@pedrobaeza pedrobaeza added this to the 10.0 milestone Dec 14, 2017
@pedrobaeza pedrobaeza mentioned this pull request Dec 14, 2017
38 tasks
@alexis-via
Copy link
Contributor Author

I guess that the "merge and squash" button of github would be good perfect for that. It avoids manual squash, which is a pretty annoying work.

@pedrobaeza
Copy link
Member

No, that's not the case. Please do it. It's the same as PEP8: at the beginning, it costs you a little time, but now you do it simultaneously.

self.pool['procurement.order'].run(
self._cr, self._uid, new_po_ids, context=self.env.context)
proc = poo.create(line._prepare_procurement_order())
procs += proc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have these created with a procurement group. When you receive in 2 steps, this allows to have the input -> stock pickings grouped by procurement group which is nice.

bealdav pushed a commit to akretion/purchase-workflow that referenced this pull request Mar 28, 2018
[MIG] sale_owner_stock_sourcing to 10.0
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022
@github-actions github-actions bot closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants