Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD purchase_price_recalculation module #725

Merged
merged 1 commit into from
Mar 31, 2020
Merged

ADD purchase_price_recalculation module #725

merged 1 commit into from
Mar 31, 2020

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Jul 22, 2019

No description provided.

@bealdav
Copy link
Member Author

bealdav commented Jul 23, 2019

please @pedrobaeza

@pedrobaeza pedrobaeza modified the milestones: 11.0, 12.0 Jul 23, 2019
@pedrobaeza
Copy link
Member

Hey, you abuse this wildcard, hehe. I will try to check later.

@bealdav
Copy link
Member Author

bealdav commented Jul 23, 2019

Thanks

legalsylvain
legalsylvain approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and one question.
Otherwise, LGTM. Usefull module. Thanks a lot @bealdav

purchase_price_recalculation/readme/DESCRIPTION.rst Show resolved Hide resolved
pedrobaeza
pedrobaeza requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting as server action allows you to recompute prices on already locked or confirmed purchase orders, which is not desirable. You can prevent that showing any error on that cases.

@bealdav
Copy link
Member Author

bealdav commented Jan 31, 2020

@pedro fixed as you would

@bealdav
Copy link
Member Author

bealdav commented Feb 7, 2020

Please @pedrobaeza could you have a look here

@bealdav
Copy link
Member Author

bealdav commented Mar 31, 2020

Please @pedrobaeza could u merge this one.
All your expectations are there.

Thanks a lot

@sebastienbeau
Copy link
Member

LGTM (code review)
/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-725-by-sebastienbeau-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3db487e. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 272feb4 into OCA:12.0 Mar 31, 2020
@bealdav bealdav deleted the 12-purch-recompute branch March 31, 2020 12:54
bealdav pushed a commit to akretion/purchase-workflow that referenced this pull request Mar 19, 2021
@OCA-git-bot
Merge PR OCA#725 into 12.0
abe0784 
Signed-off-by rousseldenis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bealdav @pedrobaeza @sebastienbeau @OCA-git-bot @legalsylvain