[12.0][MIG] purchase_requisition_auto_rfq #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addon adds a button to generate RFQ for the purchase requisition using the product.supplierinfo in order to only have the lines corresponding to the products sold by each supplier.
Here I take advantage of the new API and the assertions from nose.tools to refactor the tests and make them more readable. They are still green and should be otherwise unchanged.
The method auto_rfq_from_suppliers returned a list of ids of created RFQs. This list was used by the tests only. In production a method called by a button should just return True in case of success. Now the method returns True, and tests are adapted to figure out the created rfqs from requisition.purchase_ids instead of using the return value.
This way assert_equal gives a very nice failure singling out the different keys and values in the dictionary. This is to prepare a test on product quantities, still getting good failures if for example only the quantities for one line are different.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
|
Only a couple of line lengths "problems" remain in the Travis build report. They're quite hard to shorten without hurting the code readability, so I leave it to the reviewers to decide... 😄 |
ps-tubtim
reviewed
Dec 16, 2019
purchase_requisition_auto_rfq/tests/test_purchase_requisition.py
Outdated
Show resolved
Hide resolved
purchase_requisition_auto_rfq/tests/test_purchase_requisition.py
Outdated
Show resolved
Hide resolved
purchase_requisition_auto_rfq/tests/test_purchase_requisition.py
Outdated
Show resolved
Hide resolved
purchase_requisition_auto_rfq/tests/test_purchase_requisition.py
Outdated
Show resolved
Hide resolved
flotho
approved these changes
Dec 2, 2020
gaelTorrecillas
approved these changes
Dec 2, 2020
ps-tubtim
approved these changes
Dec 3, 2020
|
@HviorForgeFlow done |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5310681. Thanks a lot for contributing to OCA. ❤️ |
|
Phew! I can finally get on with my life 😜 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated module! 😅