[11.0][FIX] last_purchase_price_info: not rounding price to the unit #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdriaGForgeFlow
approved these changes
Jan 14, 2020
HviorForgeFlow
approved these changes
Jan 14, 2020
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Jan 14, 2020
|
Congratulations, your PR was merged at 2c3de9f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense rounding a price field with a unit measure. I don't know if function _compute_quantity is ok here but in any case, a price must have decimal precision.