Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] purchase_isolated_rfq #851

Merged

Conversation

kongrattapong
Copy link
Contributor

This module base on Module : sale_isolated_quotation

Description:
In some countries/companies, It's already common to separate these two documents.
For filing purposes, the document sequence of Requests For Quotation (RFQ) and Purchases order
has to be separated. In practice, there could be multiple RFQ open
to a vendor, yet only one RFQ get converted to the Purchases order.

This module separate RFQ and Purchases order by adding order_sequence flag in
purchase.order model.

Each type of document will have separated sequence numbering.
RFQ will have only 2 state, Draft and Done. Purchases Order work as normal.

cc. @kittiu @Oakyman

Copy link
Member

@kittiu kittiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (excel some very small comments about wording)

@kongrattapong kongrattapong force-pushed the 13.0-add-purchase_isolated_quotation branch from 20a2dfb to cd8cdb0 Compare February 20, 2020 02:35
@kongrattapong
Copy link
Contributor Author

Thank you for your review. Fixed.

Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional review
LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HviorForgeFlow
Copy link
Member

@kittiu, is it ready for merge?

@kittiu
Copy link
Member

kittiu commented Feb 21, 2020

@HviorForgeFlow yes, it is ready :)

@HviorForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-851-by-HviorForgeFlow-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b66a83b into OCA:13.0 Feb 21, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eeafc38. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants