Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX]purchase_request #852

Merged
merged 1 commit into from
Jan 31, 2020
Merged

[12.0][FIX]purchase_request #852

merged 1 commit into from
Jan 31, 2020

Conversation

AaronHForgeFlow
Copy link
Contributor

Fails when there is no group id in values, this happens on automatic reordering like reordering rules scenarios, no manual purchase requests.

HviorForgeFlow
HviorForgeFlow approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you forward port to v13 when merged? if required.

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@HviorForgeFlow
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-852-by-HviorForgeFlow-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 31, 2020
@OCA-git-bot
Merge PR #852 into 12.0
d9d1313 
Signed-off-by HviorForgeFlow
@OCA-git-bot OCA-git-bot merged commit a42f178 into OCA:12.0 Jan 31, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eacab54. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AaronHForgeFlow @HviorForgeFlow @OCA-git-bot @AdriaGForgeFlow