-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][base_import_async] - Add dependency to queue_job_batch #155
[11.0][base_import_async] - Add dependency to queue_job_batch #155
Conversation
cc @etobella @sebastienbeau @sbidoul this feature would be nice in data loads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
code Review and tested locally 😄
Yes, that's very nice :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool :)
I have tested it with the last changes of #151 and it works perfectly 😄 |
Just wondering if something like https://github.com/OCA/server-ux/blob/11.0/base_tier_validation/migrations/11.0.1.2.0/post-migrate.py#L8 is necessary installing queue_job_batch. |
@etobella that should not be necessary, the new dependency will be installed automatically. |
Yes, my mistake, I always had issues with this kind of changes, but I did manage it wrongly. |
to allow users to monitor the progress of the data load interactively.
b3f8273
to
11e6f9d
Compare
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6461dab. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
This PR adds to the 'base_import_o' module the dependency with 'queue_job_batch' so that the end user can track the progress of the load.