Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][base_import_async] - Add dependency to queue_job_batch #155

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

JordiBForgeFlow
Copy link
Sponsor Member

This PR adds to the 'base_import_o' module the dependency with 'queue_job_batch' so that the end user can track the progress of the load.

Peek 2019-07-08 13-16

@JordiBForgeFlow
Copy link
Sponsor Member Author

cc @etobella @sebastienbeau @sbidoul this feature would be nice in data loads.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
code Review and tested locally 😄

@sbidoul
Copy link
Member

sbidoul commented Jul 8, 2019

Yes, that's very nice :)

Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool :)

@etobella
Copy link
Member

etobella commented Jul 9, 2019

I have tested it with the last changes of #151 and it works perfectly 😄

@etobella
Copy link
Member

etobella commented Jul 9, 2019

Just wondering if something like https://github.com/OCA/server-ux/blob/11.0/base_tier_validation/migrations/11.0.1.2.0/post-migrate.py#L8 is necessary installing queue_job_batch.
WDYT?

@sbidoul
Copy link
Member

sbidoul commented Jul 9, 2019

@etobella that should not be necessary, the new dependency will be installed automatically.

@etobella
Copy link
Member

etobella commented Jul 9, 2019

Yes, my mistake, I always had issues with this kind of changes, but I did manage it wrongly.

to allow users to monitor the progress of the data load
interactively.
@JordiBForgeFlow JordiBForgeFlow force-pushed the 11.0-add-base_import_async-batch branch from b3f8273 to 11e6f9d Compare July 9, 2019 15:13
@sbidoul
Copy link
Member

sbidoul commented Jul 9, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 11.0-ocabot-merge-pr-155-by-sbidoul-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 11e6f9d into OCA:11.0 Jul 9, 2019
OCA-git-bot added a commit that referenced this pull request Jul 9, 2019
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6461dab. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-add-base_import_async-batch branch July 10, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants