Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] queue_job: db listener #267

Closed
wants to merge 1 commit into from

Conversation

nilshamerlinck
Copy link
Contributor

The goal of this PR is to introduce an opt-in mechanism to enable the jobrunner to take into account changes happening after server launch.

For now, it is focused on databases:

  • addition (installation of the module on a new or existing database)
  • removal (uninstallation of the module from a database).

Beyond the post_init/uninstall hooks, an http route is added to enable admins to manually trigger addition/removal events for a given database.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@nilshamerlinck nilshamerlinck changed the title [13.0][ADD] db listener [13.0][ADD] queue_job: db listener Oct 25, 2020
@nilshamerlinck nilshamerlinck force-pushed the 13.0_add_dblistener branch 2 times, most recently from fd054eb to cd074ce Compare October 25, 2020 15:36
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting implementation!
Could you test it for some time already?
I like the fact that it has to be activated explicitly, although it would be worth mentioning it in readme/CONFIGURATION.rst

BTW, you may be interested in #256 too :)

@nilshamerlinck
Copy link
Contributor Author

Hi,

Yes, we've been using it in production for some time already.

Is it ok if I favor documentation through readme/ files and remove some of the redundant module docstrings?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 13, 2022
@github-actions github-actions bot closed this Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants